From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH 4/5] ext4: fix super block checksum error
Date: Wed, 1 Feb 2023 19:46:50 +0800 [thread overview]
Message-ID: <20230201114651.4090446-5-yebin@huaweicloud.com> (raw)
In-Reply-To: <20230201114651.4090446-1-yebin@huaweicloud.com>
From: Ye Bin <yebin10@huawei.com>
As commit("ext4: fix error flag covered by journal recovery") update
error record when do journal recovery.There is need to recalculate
super block checksum after update error record or will lead to super
block checksum mismatch to data.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/ext4/ext4_jbd2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/ext4/ext4_jbd2.c b/fs/ext4/ext4_jbd2.c
index 7c0f2bed0ec4..21f4f00429a1 100644
--- a/fs/ext4/ext4_jbd2.c
+++ b/fs/ext4/ext4_jbd2.c
@@ -430,6 +430,7 @@ static int ext4_replay_callback(struct journal_s *journal,
journal->j_replay_private_data, EXT4_S_ERR_LEN);
if (sbi->s_mount_state & EXT4_ERROR_FS)
es->s_state |= cpu_to_le16(EXT4_ERROR_FS);
+ ext4_superblock_csum_set(sb);
return 0;
}
--
2.31.1
next prev parent reply other threads:[~2023-02-01 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 11:46 [PATCH 0/5] fix error flag covered by journal recovery Ye Bin
2023-02-01 11:46 ` [PATCH 1/5] jbd2: introduce callback for recovery journal Ye Bin
2023-02-01 11:46 ` [PATCH 2/5] ext4: introudce helper for jounral recover handle Ye Bin
2023-02-01 13:05 ` kernel test robot
2023-02-01 19:26 ` kernel test robot
2023-02-01 11:46 ` [PATCH 3/5] ext4: fix error flag covered by journal recovery Ye Bin
2023-02-01 11:46 ` Ye Bin [this message]
2023-02-01 11:46 ` [PATCH 5/5] ext4: make sure fs error flag setted before clear journal error Ye Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201114651.4090446-5-yebin@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).