From: zhanchengbin <zhanchengbin1@huawei.com>
To: <tytso@mit.edu>, <jack@suse.com>
Cc: <linux-ext4@vger.kernel.org>, <yi.zhang@huawei.com>,
<linfeilong@huawei.com>, <liuzhiqiang26@huawei.com>,
zhanchengbin <zhanchengbin1@huawei.com>, Jan Kara <jack@suse.cz>
Subject: [PATCH v3 1/2] ext4: fix inode tree inconsistency caused by ENOMEM in ext4_split_extent_at
Date: Tue, 7 Feb 2023 15:09:30 +0800 [thread overview]
Message-ID: <20230207070931.2189663-2-zhanchengbin1@huawei.com> (raw)
In-Reply-To: <20230207070931.2189663-1-zhanchengbin1@huawei.com>
If ENOMEM fails when the extent is splitting, we need to restore the length
of the split extent.
In the call stack of the ext4_split_extent_at function, only in
ext4_ext_create_new_leaf will it alloc memory and change the shape of the
extent tree,even if an ENOMEM is returned at this time, the extent tree is
still self-consistent, Just restore the split extent lens in the function
ext4_split_extent_at.
ext4_split_extent_at
ext4_ext_insert_extent
ext4_ext_create_new_leaf
1)ext4_ext_split
ext4_find_extent
2)ext4_ext_grow_indepth
ext4_find_extent
Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 9de1c9d1a13d..3559ea6b0781 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3251,7 +3251,7 @@ static int ext4_split_extent_at(handle_t *handle,
ext4_ext_mark_unwritten(ex2);
err = ext4_ext_insert_extent(handle, inode, ppath, &newex, flags);
- if (err != -ENOSPC && err != -EDQUOT)
+ if (err != -ENOSPC && err != -EDQUOT && err != -ENOMEM)
goto out;
if (EXT4_EXT_MAY_ZEROOUT & split_flag) {
--
2.31.1
next prev parent reply other threads:[~2023-02-07 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 7:09 [PATCH v3 0/2] fix extents need to be restored when ext4_ext_insert_extent failed zhanchengbin
2023-02-07 7:09 ` zhanchengbin [this message]
2023-02-07 7:09 ` [PATCH v3 2/2] ext4: restore len " zhanchengbin
2023-02-07 14:23 ` Jan Kara
2023-02-08 7:10 ` zhanchengbin
2023-02-08 13:12 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207070931.2189663-2-zhanchengbin1@huawei.com \
--to=zhanchengbin1@huawei.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox