From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH v2 3/6] jbd2: do extra handle when do journal recovery
Date: Fri, 10 Feb 2023 11:20:41 +0800 [thread overview]
Message-ID: <20230210032044.146115-4-yebin@huaweicloud.com> (raw)
In-Reply-To: <20230210032044.146115-1-yebin@huaweicloud.com>
From: Ye Bin <yebin10@huawei.com>
Ext4 file system's super block in journal maybe not uptodate, when
file system has error, we need set error information when do recover
uper block.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/jbd2/recovery.c | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
index 8286a9ec122f..83b1a9689984 100644
--- a/fs/jbd2/recovery.c
+++ b/fs/jbd2/recovery.c
@@ -309,6 +309,15 @@ int jbd2_journal_recover(journal_t *journal)
return 0;
}
+ if (journal->j_replay_prepare_callback) {
+ err = journal->j_replay_prepare_callback(journal);
+ if (err) {
+ jbd2_debug(1, "JBD2: failed to prepare replay %d",
+ err);
+ return err;
+ }
+ }
+
err = do_one_pass(journal, &info, PASS_SCAN);
if (!err)
err = do_one_pass(journal, &info, PASS_REVOKE);
@@ -335,6 +344,10 @@ int jbd2_journal_recover(journal_t *journal)
if (!err)
err = err2;
}
+
+ if (journal->j_replay_end_callback)
+ journal->j_replay_end_callback(journal);
+
return err;
}
@@ -687,6 +700,20 @@ static int do_one_pass(journal_t *journal,
*((__be32 *)nbh->b_data) =
cpu_to_be32(JBD2_MAGIC_NUMBER);
}
+ if (unlikely(journal->j_replay_callback)) {
+ err = journal->j_replay_callback(
+ journal, nbh);
+ if (err) {
+ printk(KERN_ERR
+ "JBD2: replay "
+ "call back "
+ "failed.\n");
+ unlock_buffer(nbh);
+ brelse(obh);
+ brelse(nbh);
+ goto failed;
+ }
+ }
BUFFER_TRACE(nbh, "marking dirty");
set_buffer_uptodate(nbh);
--
2.31.1
next prev parent reply other threads:[~2023-02-10 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 3:20 [PATCH v2 0/6] fix error flag covered by journal recovery Ye Bin
2023-02-10 3:20 ` [PATCH v2 1/6] jbd2: introduce callback for recovery journal Ye Bin
2023-02-10 3:20 ` [PATCH v2 2/6] ext4: introudce helper for jounral recover handle Ye Bin
2023-02-10 3:20 ` Ye Bin [this message]
2023-02-10 3:20 ` [PATCH v2 4/6] ext4: remove backup for super block when recovery journal Ye Bin
2023-02-10 3:20 ` [PATCH v2 5/6] ext4: fix super block checksum error Ye Bin
2023-02-10 3:20 ` [PATCH v2 6/6] ext4: make sure fs error flag setted before clear journal error Ye Bin
2023-02-10 11:56 ` [PATCH v2 0/6] fix error flag covered by journal recovery Jan Kara
2023-02-10 12:47 ` Zhang Yi
2023-02-15 1:14 ` yebin (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230210032044.146115-4-yebin@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).