From: zhanchengbin <zhanchengbin1@huawei.com>
To: <tytso@mit.edu>, <jack@suse.com>
Cc: <linux-ext4@vger.kernel.org>, <yi.zhang@huawei.com>,
<linfeilong@huawei.com>, <liuzhiqiang26@huawei.com>,
zhanchengbin <zhanchengbin1@huawei.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH v5 2/2] ext4: clear the verified flag of the modified leaf or idx if error
Date: Mon, 13 Feb 2023 16:05:14 +0800 [thread overview]
Message-ID: <20230213080514.535568-3-zhanchengbin1@huawei.com> (raw)
In-Reply-To: <20230213080514.535568-1-zhanchengbin1@huawei.com>
Clear the verified flag from the modified bh when failed in ext4_ext_rm_idx
or ext4_ext_correct_indexes.
In this way, the start value of the logical block itself and its
parents' will be checked in ext4_valid_extent_entries.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Link: https://lore.kernel.org/oe-kbuild-all/202302131414.5RKeHgAZ-lkp@intel.com/
Link: https://lore.kernel.org/oe-kbuild-all/202302131407.XrieHNuN-lkp@intel.com/
---
fs/ext4/extents.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 0f95e857089e..bbf34679e10c 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1756,6 +1756,8 @@ static int ext4_ext_correct_indexes(handle_t *handle, struct inode *inode,
if (err)
break;
}
+ while (!(k < 0) && k++ < depth)
+ clear_buffer_verified(path[k].p_bh);
return err;
}
@@ -2304,6 +2306,7 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode,
{
int err;
ext4_fsblk_t leaf;
+ int b_depth = depth;
/* free index block */
depth--;
@@ -2345,6 +2348,9 @@ static int ext4_ext_rm_idx(handle_t *handle, struct inode *inode,
if (err)
break;
}
+ while (!(depth < 0) && depth++ < b_depth - 1)
+ clear_buffer_verified(path[depth].p_bh);
+
return err;
}
--
2.31.1
next prev parent reply other threads:[~2023-02-13 7:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 8:05 [PATCH v5 0/2] fix extents need to be restored when ext4_ext_insert_extent failed zhanchengbin
2023-02-13 8:05 ` [PATCH v5 1/2] ext4: fix inode tree inconsistency caused by ENOMEM in ext4_split_extent_at zhanchengbin
2023-02-13 8:05 ` zhanchengbin [this message]
2023-02-14 12:52 ` [PATCH v5 2/2] ext4: clear the verified flag of the modified leaf or idx if error Jan Kara
2023-02-16 7:25 ` zhanchengbin
2023-02-16 13:03 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213080514.535568-3-zhanchengbin1@huawei.com \
--to=zhanchengbin1@huawei.com \
--cc=jack@suse.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=lkp@intel.com \
--cc=tytso@mit.edu \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox