From: Ye Bin <yebin@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, Ye Bin <yebin10@huawei.com>
Subject: [PATCH v3 1/2] ext4: commit super block if fs record error when journal record without error
Date: Tue, 14 Feb 2023 10:29:04 +0800 [thread overview]
Message-ID: <20230214022905.765088-2-yebin@huaweicloud.com> (raw)
In-Reply-To: <20230214022905.765088-1-yebin@huaweicloud.com>
From: Ye Bin <yebin10@huawei.com>
Now, 'es->s_state' maybe covered by recover journal. And journal errno
maybe not recorded in journal sb as IO error. ext4_update_super() only
update error information when 'sbi->s_add_error_count' large than zero.
Then 'EXT4_ERROR_FS' flag maybe lost.
To solve above issue commit error information after recover journal.
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
fs/ext4/super.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index dc3907dff13a..b94754ba8556 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5932,6 +5932,18 @@ static int ext4_load_journal(struct super_block *sb,
goto err_out;
}
+ if (unlikely(es->s_error_count && !jbd2_journal_errno(journal) &&
+ !(le16_to_cpu(es->s_state) & EXT4_ERROR_FS))) {
+ EXT4_SB(sb)->s_mount_state |= EXT4_ERROR_FS;
+ es->s_state |= cpu_to_le16(EXT4_ERROR_FS);
+ err = ext4_commit_super(sb);
+ if (err) {
+ ext4_msg(sb, KERN_ERR,
+ "Failed to commit error information, please repair fs force!");
+ goto err_out;
+ }
+ }
+
EXT4_SB(sb)->s_journal = journal;
err = ext4_clear_journal_err(sb, es);
if (err) {
--
2.31.1
next prev parent reply other threads:[~2023-02-14 2:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 2:29 [PATCH v3 0/2] fix error flag covered by journal recovery Ye Bin
2023-02-14 2:29 ` Ye Bin [this message]
2023-02-16 7:17 ` [PATCH v3 1/2] ext4: commit super block if fs record error when journal record without error Baokun Li
2023-02-16 7:44 ` yebin (H)
2023-02-16 9:17 ` Baokun Li
2023-02-16 9:29 ` yebin (H)
2023-02-16 17:31 ` Jan Kara
2023-02-17 1:43 ` Baokun Li
2023-02-17 1:44 ` yebin (H)
2023-02-17 10:56 ` Jan Kara
2023-02-18 2:18 ` yebin (H)
2023-02-27 11:20 ` Jan Kara
2023-02-28 2:24 ` yebin (H)
2023-03-01 9:07 ` Jan Kara
2023-02-14 2:29 ` [PATCH v3 2/2] ext4: make sure fs error flag setted before clear journal error Ye Bin
2023-02-16 7:17 ` Baokun Li
2023-02-16 17:20 ` Jan Kara
2023-02-16 7:18 ` [PATCH v3 0/2] fix error flag covered by journal recovery Baokun Li
2023-02-16 8:12 ` yebin (H)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230214022905.765088-2-yebin@huaweicloud.com \
--to=yebin@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).