From: Jan Kara <jack@suse.cz>
To: syzbot <syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com>
Cc: hdanton@sina.com, jack@suse.com, jack@suse.cz,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tytso@mit.edu
Subject: Re: [syzbot] [ext4?] possible deadlock in jbd2_log_wait_commit
Date: Wed, 1 Mar 2023 13:42:49 +0100 [thread overview]
Message-ID: <20230301124249.tj7oub3r35q5z3rx@quack3> (raw)
In-Reply-To: <0000000000003845ba05f5d3e416@google.com>
On Wed 01-03-23 02:08:19, syzbot wrote:
> syzbot has bisected this issue to:
>
> commit 0813299c586b175d7edb25f56412c54b812d0379
> Author: Jan Kara <jack@suse.cz>
> Date: Thu Jan 26 11:22:21 2023 +0000
>
> ext4: Fix possible corruption when moving a directory
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14845d50c80000
> start commit: e492250d5252 Merge tag 'pwm/for-6.3-rc1' of git://git.kern..
> git tree: upstream
> final oops: https://syzkaller.appspot.com/x/report.txt?x=16845d50c80000
> console output: https://syzkaller.appspot.com/x/log.txt?x=12845d50c80000
> kernel config: https://syzkaller.appspot.com/x/.config?x=f763d89e26d3d4c4
> dashboard link: https://syzkaller.appspot.com/bug?extid=9d16c39efb5fade84574
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11d96208c80000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=176d917f480000
>
> Reported-by: syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com
> Fixes: 0813299c586b ("ext4: Fix possible corruption when moving a directory")
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
Drat, yeah, lockdep is actually right. We should not be grabbing i_rwsem
while having transaction started in ext4_rename(). I'm somewhat surprised
we didn't hit this lockdep warning earlier during the testing. So we need
to move the locking earlier in ext4_rename(). I'll send a patch...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-03-01 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 21:04 [syzbot] [ext4?] possible deadlock in jbd2_log_wait_commit syzbot
2023-03-01 1:46 ` syzbot
2023-03-01 10:08 ` syzbot
2023-03-01 12:42 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301124249.tj7oub3r35q5z3rx@quack3 \
--to=jack@suse.cz \
--cc=hdanton@sina.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+9d16c39efb5fade84574@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox