From: Jan Kara <jack@suse.cz>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org,
syzbot+4fec412f59eba8c01b77@syzkaller.appspotmail.com
Subject: Re: [PATCH 2/2] ext2: Check block size validity during mount
Date: Wed, 1 Mar 2023 14:05:12 +0100 [thread overview]
Message-ID: <20230301130512.2vunrj4mspbkwgah@quack3> (raw)
In-Reply-To: <d2a5be55-4bcb-da7e-fae5-9cc598223b17@linaro.org>
On Wed 01-03-23 11:37:20, Tudor Ambarus wrote:
> Hi!
>
> On 3/1/23 11:12, Jan Kara wrote:
> > Check that log of block size stored in the superblock has sensible
> > value. Otherwise the shift computing the block size can overflow leading
> > to undefined behavior.
> >
> > Reported-by: syzbot+4fec412f59eba8c01b77@syzkaller.appspotmail.com
>
> Would be helpful to also have:
> LINK: https://syzkaller.appspot.com/bug?extid=4fec412f59eba8c01b77
> a "Fixes:" tag and
> Cc: stable@vger.kernel.org
Well, Fixes tag doesn't really make sense here. The behavior is there since
forever... I've added the Link and CC tags. Thanks for the suggestion.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-03-01 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 11:12 [PATCH 0/2] ext2: Refuse filesystems with invalid block size Jan Kara
2023-03-01 11:12 ` [PATCH 1/2] ext2: Correct maximum ext2 filesystem " Jan Kara
2023-03-01 11:12 ` [PATCH 2/2] ext2: Check block size validity during mount Jan Kara
2023-03-01 11:37 ` Tudor Ambarus
2023-03-01 13:05 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301130512.2vunrj4mspbkwgah@quack3 \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=syzbot+4fec412f59eba8c01b77@syzkaller.appspotmail.com \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox