From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linfeilong@huawei.com
Subject: Re: [PATCH 3/4] ext4: remove unused group parameter in ext4_block_bitmap_csum_verify
Date: Tue, 7 Mar 2023 12:08:30 +0100 [thread overview]
Message-ID: <20230307110830.w7nuk3mrgjgfezig@quack3> (raw)
In-Reply-To: <20230221203027.2359920-4-shikemeng@huaweicloud.com>
On Wed 22-02-23 04:30:26, Kemeng Shi wrote:
> Remove unused group parameter in ext4_block_bitmap_csum_verify.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/balloc.c | 3 +--
> fs/ext4/bitmap.c | 2 +-
> fs/ext4/ext4.h | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 689edfed231a..49fdb758b0e4 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -385,8 +385,7 @@ static int ext4_validate_block_bitmap(struct super_block *sb,
> ext4_lock_group(sb, block_group);
> if (buffer_verified(bh))
> goto verified;
> - if (unlikely(!ext4_block_bitmap_csum_verify(sb, block_group,
> - desc, bh) ||
> + if (unlikely(!ext4_block_bitmap_csum_verify(sb, desc, bh) ||
> ext4_simulate_fail(sb, EXT4_SIM_BBITMAP_CRC))) {
> ext4_unlock_group(sb, block_group);
> ext4_error(sb, "bg %u: bad block bitmap checksum", block_group);
> diff --git a/fs/ext4/bitmap.c b/fs/ext4/bitmap.c
> index 0186b894f5b3..3b83d979a650 100644
> --- a/fs/ext4/bitmap.c
> +++ b/fs/ext4/bitmap.c
> @@ -54,7 +54,7 @@ void ext4_inode_bitmap_csum_set(struct super_block *sb,
> gdp->bg_inode_bitmap_csum_hi = cpu_to_le16(csum >> 16);
> }
>
> -int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,
> +int ext4_block_bitmap_csum_verify(struct super_block *sb,
> struct ext4_group_desc *gdp,
> struct buffer_head *bh)
> {
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index aa6948d12ede..04447640b4f4 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2685,7 +2685,7 @@ int ext4_inode_bitmap_csum_verify(struct super_block *sb,
> void ext4_block_bitmap_csum_set(struct super_block *sb, ext4_group_t group,
> struct ext4_group_desc *gdp,
> struct buffer_head *bh);
> -int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,
> +int ext4_block_bitmap_csum_verify(struct super_block *sb,
> struct ext4_group_desc *gdp,
> struct buffer_head *bh);
>
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2023-03-07 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 20:30 [PATCH 0/4] Remove unused group parameter in bitmap checksum Kemeng Shi
2023-02-21 20:30 ` [PATCH 1/4] ext4: remove unused group parameter in ext4_inode_bitmap_csum_verify Kemeng Shi
2023-03-07 11:07 ` Jan Kara
2023-02-21 20:30 ` [PATCH 2/4] ext4: remove unused group parameter in ext4_inode_bitmap_csum_set Kemeng Shi
2023-03-07 11:08 ` Jan Kara
2023-02-21 20:30 ` [PATCH 3/4] ext4: remove unused group parameter in ext4_block_bitmap_csum_verify Kemeng Shi
2023-03-07 11:08 ` Jan Kara [this message]
2023-02-21 20:30 ` [PATCH 4/4] ext4: remove unused group parameter in ext4_block_bitmap_csum_set Kemeng Shi
2023-03-07 11:09 ` Jan Kara
2023-03-17 1:52 ` [PATCH 0/4] Remove unused group parameter in bitmap checksum Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230307110830.w7nuk3mrgjgfezig@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).