From: Eric Biggers <ebiggers@kernel.org>
To: Tom Rix <trix@redhat.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: remove unneeded check of nr_to_submit
Date: Thu, 16 Mar 2023 21:58:36 -0700 [thread overview]
Message-ID: <20230317045836.GA882@sol.localdomain> (raw)
In-Reply-To: <20230316204831.2472537-1-trix@redhat.com>
On Thu, Mar 16, 2023 at 04:48:31PM -0400, Tom Rix wrote:
> cppcheck reports
> fs/ext4/page-io.c:516:51: style:
> Condition 'nr_to_submit' is always true [knownConditionTrueFalse]
> if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) {
> ^
> This earlier check to bail, makes this check unncessary
> /* Nothing to submit? Just unlock the page... */
> if (!nr_to_submit)
> return 0;
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Maybe add:
Fixes: dff4ac75eeee ("ext4: move keep_towrite handling to ext4_bio_write_page()")
Either way, looks good to me.
Reviewed-by: Eric Biggers <ebiggers@google.com>
- Eric
next prev parent reply other threads:[~2023-03-17 4:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 20:48 [PATCH] ext4: remove unneeded check of nr_to_submit Tom Rix
2023-03-17 4:58 ` Eric Biggers [this message]
2023-03-17 11:08 ` Tom Rix
2023-04-20 13:47 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317045836.GA882@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).