public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: "wangjianjian (C)" <wangjianjian3@huawei.com>
Cc: Zhang Yi <yi.zhang@huaweicloud.com>,
	linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
	jack@suse.cz, yi.zhang@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH v4 1/2] jbd2: continue to record log between each mount
Date: Fri, 17 Mar 2023 11:25:21 -0400	[thread overview]
Message-ID: <20230317152521.GA3270589@mit.edu> (raw)
In-Reply-To: <021bd760-a3f5-14fa-ca64-27882803abab@huawei.com>

On Fri, Mar 17, 2023 at 06:33:50PM +0800, wangjianjian (C) wrote:
> Do we need update document/filesystems/ext4/journal.rst ?
> 
> On 2023/3/17 17:09, Zhang Yi wrote:
> > -	__u32	s_padding[41];
> > +	__be32	s_head;			/* blocknr of head of log, only uptodate
> > +					 * while the filesystem is clean */
> > +/* 0x005C */
> > +	__u32	s_padding[40];
> >   	__be32	s_checksum;		/* crc32c(superblock) */

Yes, please update journal.rst in the patch.

						- Ted


  reply	other threads:[~2023-03-17 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-17  9:09 [PATCH v4 0/2] ext4, jbd2: journal cycled record transactions between each mount Zhang Yi
2023-03-17  9:09 ` [PATCH v4 1/2] jbd2: continue to record log " Zhang Yi
2023-03-17 10:33   ` wangjianjian (C)
2023-03-17 15:25     ` Theodore Ts'o [this message]
2023-03-18  6:13       ` Zhang Yi
2023-03-17 13:01   ` Jan Kara
2023-03-17  9:09 ` [PATCH v4 2/2] ext4: add journal cycled recording support Zhang Yi
2023-03-17 13:01   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230317152521.GA3270589@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=wangjianjian3@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yi.zhang@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox