From: "Theodore Ts'o" <tytso@mit.edu>
To: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
adilger@whamcloud.com, Jan Kara <jack@suse.cz>,
linfeilong <linfeilong@huawei.com>,
wuguanghao <wuguanghao3@huawei.com>,
zhanchengbin <zhanchengbin1@huawei.com>,
libaokun1@huawei.com
Subject: Re: [PATCH] tune2fs: check whether dev is mounted or in use before setting
Date: Sat, 18 Mar 2023 12:24:21 -0400 [thread overview]
Message-ID: <20230318162421.GB11916@mit.edu> (raw)
In-Reply-To: <8babc8eb-1713-91c9-1efa-496909340a6f@huawei.com>
On Sat, Mar 18, 2023 at 11:36:03AM +0800, Zhiqiang Liu wrote:
> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
>
> tune2fs is used to adjust various tunable filesystem pars, which
> may conflict with kernel operations. So we should check whether
> device is mounted or in use at the begin similar to e2fsck and mke2fs.
>
> Of course, we can ignore this check if -f is set.
Tune2fs is designed to work on mounted file systems. There are
individual checks for those changes which can not be safely done on
mounted file systems, but most changes are safe to do on mounted file
systems.
Cheers,
- Ted
next prev parent reply other threads:[~2023-03-18 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 3:36 [PATCH] tune2fs: check whether dev is mounted or in use before setting Zhiqiang Liu
2023-03-18 16:24 ` Theodore Ts'o [this message]
2023-03-19 5:44 ` Zhiqiang Liu
2023-03-19 13:02 ` Theodore Ts'o
2023-03-20 2:08 ` Zhiqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318162421.GB11916@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=wuguanghao3@huawei.com \
--cc=zhanchengbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox