From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@kernel.org>,
Dan Carpenter <error27@gmail.com>,
linux-ext4@vger.kernel.org
Subject: Re: [bug report] ext4: Fix possible corruption when moving a directory
Date: Mon, 20 Mar 2023 12:03:29 +0100 [thread overview]
Message-ID: <20230320110329.ckxg5mrenwfo5f4c@quack3> (raw)
In-Reply-To: <20230318020743.GO860405@mit.edu>
On Fri 17-03-23 22:07:43, Theodore Ts'o wrote:
> On Wed, Mar 08, 2023 at 11:42:34AM +0100, Jan Kara wrote:
> > > That analysis looks correct. FYI, I think this is the same as the syzbot report
> > > "[ext4?] WARNING: bad unlock balance in ext4_rename2"
> > > (https://lore.kernel.org/linux-ext4/000000000000435c6905f639ae8e@google.com).
> >
> > Good spotting! This should be fixed (along with the lock ordering problem)
> > by 3c92792da8506 ("ext4: Fix deadlock during directory rename") Ted has
> > just merged couple hours ago.
>
> Unfortunately, the Syzkaller report is still triggering after the
> merge and commit 3c92792da8506. The double unlock is still there, and
> so the following fix is still needed (which I will be sending to Linus).
Bah, right. Thanks for fixing this!
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-03-20 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 15:56 [bug report] ext4: Fix possible corruption when moving a directory Dan Carpenter
2023-03-07 19:18 ` Eric Biggers
2023-03-08 10:42 ` Jan Kara
2023-03-18 2:07 ` Theodore Ts'o
2023-03-20 11:03 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230320110329.ckxg5mrenwfo5f4c@quack3 \
--to=jack@suse.cz \
--cc=ebiggers@kernel.org \
--cc=error27@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox