From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F97EC76196 for ; Mon, 3 Apr 2023 13:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232324AbjDCNVa (ORCPT ); Mon, 3 Apr 2023 09:21:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232284AbjDCNV3 (ORCPT ); Mon, 3 Apr 2023 09:21:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A3BA11646; Mon, 3 Apr 2023 06:21:26 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91E4161B16; Mon, 3 Apr 2023 13:21:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C58BC433EF; Mon, 3 Apr 2023 13:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680528085; bh=w4t3z/emlEMWCujalYa1Rep13uYkd+UePvxbsW/Wm3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mSP7BtVKL378nnD7y4UBNufsx4oyublkb/avMKd8md/0VlMdoP61p2J7WahOZkm1o W9cKvl6o6L8z0ZWh9KzjDurERq9v3NNLwYbKViEzVvZLCKLhmKH9olXrSZvEi4IYaz VxbFgSunKEa6h2UI1RsqO+ydLV5u9WAEy8I83zWI= Date: Mon, 3 Apr 2023 15:21:22 +0200 From: Greg KH To: Tudor Ambarus Cc: stable@vger.kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, boyu.mt@taobao.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, leejones@google.com, yebin10@huawei.com, syzbot+4faa160fa96bfba639f8@syzkaller.appspotmail.com, jun.nie@linaro.org, stable@kernel.org Subject: Re: [PATCH v2][for-stable 5.10, 5.4, 4.19, 4.14] ext4: fix kernel BUG in 'ext4_write_inline_data_end()' Message-ID: <2023040311-synthesis-parakeet-0c6a@gregkh> References: <20230330134233.3407390-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230330134233.3407390-1-tudor.ambarus@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Mar 30, 2023 at 01:42:33PM +0000, Tudor Ambarus wrote: > From: Ye Bin > > [ Upstream commit 5c099c4fdc438014d5893629e70a8ba934433ee8 ] > > Syzbot report follow issue: > ------------[ cut here ]------------ > kernel BUG at fs/ext4/inline.c:227! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > CPU: 1 PID: 3629 Comm: syz-executor212 Not tainted 6.1.0-rc5-syzkaller-00018-g59d0d52c30d4 #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 > RIP: 0010:ext4_write_inline_data+0x344/0x3e0 fs/ext4/inline.c:227 > RSP: 0018:ffffc90003b3f368 EFLAGS: 00010293 > RAX: 0000000000000000 RBX: ffff8880704e16c0 RCX: 0000000000000000 > RDX: ffff888021763a80 RSI: ffffffff821e31a4 RDI: 0000000000000006 > RBP: 000000000006818e R08: 0000000000000006 R09: 0000000000068199 > R10: 0000000000000079 R11: 0000000000000000 R12: 000000000000000b > R13: 0000000000068199 R14: ffffc90003b3f408 R15: ffff8880704e1c82 > FS: 000055555723e3c0(0000) GS:ffff8880b9b00000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007fffe8ac9080 CR3: 0000000079f81000 CR4: 0000000000350ee0 > Call Trace: > > ext4_write_inline_data_end+0x2a3/0x12f0 fs/ext4/inline.c:768 > ext4_write_end+0x242/0xdd0 fs/ext4/inode.c:1313 > ext4_da_write_end+0x3ed/0xa30 fs/ext4/inode.c:3063 > generic_perform_write+0x316/0x570 mm/filemap.c:3764 > ext4_buffered_write_iter+0x15b/0x460 fs/ext4/file.c:285 > ext4_file_write_iter+0x8bc/0x16e0 fs/ext4/file.c:700 > call_write_iter include/linux/fs.h:2191 [inline] > do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 > do_iter_write+0x182/0x700 fs/read_write.c:861 > vfs_iter_write+0x74/0xa0 fs/read_write.c:902 > iter_file_splice_write+0x745/0xc90 fs/splice.c:686 > do_splice_from fs/splice.c:764 [inline] > direct_splice_actor+0x114/0x180 fs/splice.c:931 > splice_direct_to_actor+0x335/0x8a0 fs/splice.c:886 > do_splice_direct+0x1ab/0x280 fs/splice.c:974 > do_sendfile+0xb19/0x1270 fs/read_write.c:1255 > __do_sys_sendfile64 fs/read_write.c:1323 [inline] > __se_sys_sendfile64 fs/read_write.c:1309 [inline] > __x64_sys_sendfile64+0x1d0/0x210 fs/read_write.c:1309 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > ---[ end trace 0000000000000000 ]--- > > Above issue may happens as follows: > ext4_da_write_begin > ext4_da_write_inline_data_begin > ext4_da_convert_inline_data_to_extent > ext4_clear_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA); > ext4_da_write_end > > ext4_run_li_request > ext4_mb_prefetch > ext4_read_block_bitmap_nowait > ext4_validate_block_bitmap > ext4_mark_group_bitmap_corrupted(sb, block_group, EXT4_GROUP_INFO_BBITMAP_CORRUPT) > percpu_counter_sub(&sbi->s_freeclusters_counter,grp->bb_free); > -> sbi->s_freeclusters_counter become zero > ext4_da_write_begin > if (ext4_nonda_switch(inode->i_sb)) -> As freeclusters_counter is zero will return true > *fsdata = (void *)FALL_BACK_TO_NONDELALLOC; > ext4_write_begin > ext4_da_write_end > if (write_mode == FALL_BACK_TO_NONDELALLOC) > ext4_write_end > if (inline_data) > ext4_write_inline_data_end > ext4_write_inline_data > BUG_ON(pos + len > EXT4_I(inode)->i_inline_size); > -> As inode is already convert to extent, so 'pos + len' > inline_size > -> then trigger BUG. > > To solve this issue, instead of checking ext4_has_inline_data() which > is only cleared after data has been written back, check the > EXT4_STATE_MAY_INLINE_DATA flag in ext4_write_end(). > > Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data") > Reported-by: syzbot+4faa160fa96bfba639f8@syzkaller.appspotmail.com > Reported-by: Jun Nie > Signed-off-by: Ye Bin > Link: https://lore.kernel.org/r/20221206144134.1919987-1-yebin@huaweicloud.com > Signed-off-by: Theodore Ts'o > Cc: stable@kernel.org > [ta: Fix conflict in if expression and use the local variable inline_data > as it is initialized with ext4_has_inline_data(inode) anyway.] > Signed-off-by: Tudor Ambarus > --- > v2: update description on how the conflict was fixed Much better, thanks! Now queued up. greg k-h