From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23EF8C76188 for ; Wed, 5 Apr 2023 14:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238071AbjDEOY7 (ORCPT ); Wed, 5 Apr 2023 10:24:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238474AbjDEOYw (ORCPT ); Wed, 5 Apr 2023 10:24:52 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 270ED26B2; Wed, 5 Apr 2023 07:24:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A40E1625AC; Wed, 5 Apr 2023 14:24:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B622FC433EF; Wed, 5 Apr 2023 14:24:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1680704685; bh=eiBbg0MwdqCSRyYPdbIMvUwBVY7mO5kW4nAZe/cwBpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2SIuXsCF84/UtNsZZtbFPgdUTP6vHW1ckAOTWhfLN5V+9+ZijnMbtMH0OgHvVetSI k6UFaZTF/3U9n90SV6VKhx3RZc1YLh7O9xEO53hn4u6iCxmbPpuvJgP0LjhHBVQ0qx 1fAlF6DWaSE7F9xCuiaGIkZnBvQJRjw8DdvnAT7k= Date: Wed, 5 Apr 2023 16:24:42 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Kees Cook , Cezary Rojewski , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Ts'o , Jan Kara , "Rafael J. Wysocki" Subject: Re: [PATCH v2 0/3] lib/string_helpers et al.: Change return value of strreplace() Message-ID: <2023040523-unworthy-uncured-1eab@gregkh> References: <20230323123704.37983-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote: > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote: > > It's more convenient to have strreplace() to return the pointer to > > the string itself. This will help users to make their code better. > > > > The patch 1 kills the only user of the returned value of strreplace(), > > Patch 2 converts the return value of strreplace(). And patch 3 shows > > how it may be useful. That said, the series can be routed via fs tree, > > with or without the last patch. > > Since there are no comments, who can apply this (patches 1 and 2)? > Greg, are you fine with the kobject change? Sure, want me to take them all through my driver-core tree? thanks, greg k-h