From: Jan Kara <jack@suse.cz>
To: Wu Bo <wubo@huaweicloud.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
tytso@mit.edu, qiuchangqi.qiu@huawei.com, wubo40@huawei.com
Subject: Re: [PATCH] ext4: Remove unnecessary variable assignments
Date: Fri, 28 Apr 2023 16:58:32 +0200 [thread overview]
Message-ID: <20230428145832.azuluj4rnqurphyg@quack3> (raw)
In-Reply-To: <1681731135-18768-1-git-send-email-wubo@huaweicloud.com>
On Mon 17-04-23 19:32:15, Wu Bo wrote:
> Just remove unnecessary variable assignments.
>
> Signed-off-by: Wu Bo <wubo@huaweicloud.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/mballoc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 5b2ae37..f0b790d 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -5842,7 +5842,6 @@ static void ext4_free_blocks_simple(struct inode *inode, ext4_fsblk_t block,
> ext4_get_group_no_and_offset(sb, block, &group, &blkoff);
> bitmap_bh = ext4_read_block_bitmap(sb, group);
> if (IS_ERR(bitmap_bh)) {
> - err = PTR_ERR(bitmap_bh);
> pr_warn("Failed to read block bitmap\n");
> return;
> }
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2023-04-28 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 11:32 [PATCH] ext4: Remove unnecessary variable assignments Wu Bo
2023-04-28 14:58 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428145832.azuluj4rnqurphyg@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiuchangqi.qiu@huawei.com \
--cc=tytso@mit.edu \
--cc=wubo40@huawei.com \
--cc=wubo@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox