From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C40E5C77B7A for ; Thu, 1 Jun 2023 15:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235100AbjFAP2s (ORCPT ); Thu, 1 Jun 2023 11:28:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234915AbjFAP2f (ORCPT ); Thu, 1 Jun 2023 11:28:35 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17371E5C; Thu, 1 Jun 2023 08:28:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A484321999; Thu, 1 Jun 2023 15:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685633266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bzP3jLe8H8GOVTU+gtWIF9QQ1w/ZlpecHavzqINdb94=; b=gOv8ln8aI+gXFZjWVdmCA8Wjxd4LICDM5AcA4HSkflUYb41Mcds6Sig/+gvw1r+us6LFoO kVxojpvhhIe6pB3ye46OJCnKyH8RZgj7hBe/YL9nHIGq4Dz3fwiNpUvsP1RR+d1U0PwiX7 f67hxyD7bPdnQhqhQaCuY/jq4Qu3bLU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685633266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bzP3jLe8H8GOVTU+gtWIF9QQ1w/ZlpecHavzqINdb94=; b=2SzoaO5XBuvNM4t9ZY5UOUFL7l/socW8dcuNJwrzQ6bLiNuaC9FS97mPz/t3+MWR1OT01Q UvfkwX48LkI2rvCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9558513441; Thu, 1 Jun 2023 15:27:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qntwJPK4eGSLbAAAMHmgww (envelope-from ); Thu, 01 Jun 2023 15:27:46 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 18AC5A0754; Thu, 1 Jun 2023 17:27:46 +0200 (CEST) Date: Thu, 1 Jun 2023 17:27:46 +0200 From: Jan Kara To: Theodore Ts'o Cc: Jan Kara , Al Viro , linux-fsdevel@vger.kernel.org, Christian Brauner , Miklos Szeredi , "Darrick J. Wong" , Jaegeuk Kim , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, stable@vger.kernel.org Subject: Re: [PATCH v2 1/6] ext4: Remove ext4 locking of moved directory Message-ID: <20230601152746.kqykcztndxvxbbf7@quack3> References: <20230601104525.27897-1-jack@suse.cz> <20230601105830.13168-1-jack@suse.cz> <20230601145222.GB1069561@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601145222.GB1069561@mit.edu> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu 01-06-23 10:52:22, Theodore Ts'o wrote: > On Thu, Jun 01, 2023 at 12:58:21PM +0200, Jan Kara wrote: > > Remove locking of moved directory in ext4_rename2(). We will take care > > of it in VFS instead. This effectively reverts commit 0813299c586b > > ("ext4: Fix possible corruption when moving a directory") and followup > > fixes. > > Remind me --- commit 0813299c586b is not actually causing any > problems; it's just not fully effective at solving the problem. Is > that correct? Yes, correct. > In other words, is there a rush in trying to get this revert to Linus > during this cycle as a regression fix? > > I think the answer is no, and we can just let this full patch series > go in via the vfs branch during the next merge window, but I just > wanted to make sure. Exactly, that's my plan as well. Honza -- Jan Kara SUSE Labs, CR