From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8564EB64DB for ; Mon, 19 Jun 2023 09:56:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbjFSJ4U (ORCPT ); Mon, 19 Jun 2023 05:56:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230469AbjFSJ4T (ORCPT ); Mon, 19 Jun 2023 05:56:19 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 361C9DE; Mon, 19 Jun 2023 02:56:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 732D121890; Mon, 19 Jun 2023 09:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687168576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHDB1goOIdClF7fSskWHB6HJ+dOH2Pf0/f+fBVNZKrI=; b=DIpsb4EieamYZhyKaJCFxmJC6JO0cddEVy/1OyL8WDxOPeQGOtKMiVGqTxsIbrpLXpkxhN VXpLK+f++/JuAhTySMfcouo/j1p7MERtfqsoS0ULoRTD0YkD5mE84xRomR8ypCnrHqfM37 H8ssxvhCnHNv2dPJxVM4ndebL7WLdsY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687168576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EHDB1goOIdClF7fSskWHB6HJ+dOH2Pf0/f+fBVNZKrI=; b=2cxWY7Vw2OWzwjCUYjwhmawhiT+eBMOhUzAYEEySvXUmGZ1RMij4oQYT3UbwcV7Dqk24XK dqaTNsjGYQYbioDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6485A138E8; Mon, 19 Jun 2023 09:56:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m1SIGEAmkGTiNgAAMHmgww (envelope-from ); Mon, 19 Jun 2023 09:56:16 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id F00FAA0755; Mon, 19 Jun 2023 11:56:15 +0200 (CEST) Date: Mon, 19 Jun 2023 11:56:15 +0200 From: Jan Kara To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [PATCH v1 3/5] ext4: No need to check return value of block_commit_write() Message-ID: <20230619095615.pr6dw773bsruwqar@quack3> References: <20230618213250.694110-1-beanhuo@iokpp.de> <20230618213250.694110-4-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230618213250.694110-4-beanhuo@iokpp.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun 18-06-23 23:32:48, Bean Huo wrote: > From: Bean Huo > > Remove unnecessary check on the return value of block_commit_write(). > > Signed-off-by: Bean Huo Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ext4/move_extent.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c > index b5af2fc03b2f..f4b4861a74ee 100644 > --- a/fs/ext4/move_extent.c > +++ b/fs/ext4/move_extent.c > @@ -392,14 +392,11 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode, > for (i = 0; i < block_len_in_page; i++) { > *err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0); > if (*err < 0) > - break; > + goto repair_branches; > bh = bh->b_this_page; > } > - if (!*err) > - *err = block_commit_write(&folio[0]->page, from, from + replaced_size); > > - if (unlikely(*err < 0)) > - goto repair_branches; > + block_commit_write(&folio[0]->page, from, from + replaced_size); > > /* Even in case of data=writeback it is reasonable to pin > * inode to transaction, to prevent unexpected data loss */ > -- > 2.34.1 > -- Jan Kara SUSE Labs, CR