From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB35EB64D9 for ; Mon, 19 Jun 2023 09:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231777AbjFSJ46 (ORCPT ); Mon, 19 Jun 2023 05:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231720AbjFSJ4g (ORCPT ); Mon, 19 Jun 2023 05:56:36 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD4CA12F; Mon, 19 Jun 2023 02:56:31 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A8DE51F45A; Mon, 19 Jun 2023 09:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1687168589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NQVAvWxLe8ddOnT0x92jyszEXcQ2Ez0WGCSpMTarvf8=; b=O7ivCX7C1pmL0yBAJe7Ne+Y+kth455ZJUYF10UMTbSbKG39ENlmViLSrEC1BGNn2VxTtMc 3CRtP2k1YSIlYIVybmbfACDfVqq4ifeSNuarWY2bERzoWseJBGvX4b/BH4FHxoL7kcshex vMQP+ioZCg5BLuPhPVBDJESP+ixptYw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1687168589; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NQVAvWxLe8ddOnT0x92jyszEXcQ2Ez0WGCSpMTarvf8=; b=yVCXTvzoVEmetaKWn5zm+QI1WM708Q/50rB5VjHCe1WHoS6NF1tvR9p7MyqanZqNB4z/dn GVYPWKjBPL19cvAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D3FE138E8; Mon, 19 Jun 2023 09:56:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9Q9gJk0mkGT2NgAAMHmgww (envelope-from ); Mon, 19 Jun 2023 09:56:29 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 45982A0755; Mon, 19 Jun 2023 11:56:29 +0200 (CEST) Date: Mon, 19 Jun 2023 11:56:29 +0200 From: Jan Kara To: Bean Huo Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, akpm@linux-foundation.org, jack@suse.cz, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, beanhuo@micron.com Subject: Re: [PATCH v1 4/5] fs/ocfs2: No need to check return value of block_commit_write() Message-ID: <20230619095629.qicy2guryvryc7el@quack3> References: <20230618213250.694110-1-beanhuo@iokpp.de> <20230618213250.694110-5-beanhuo@iokpp.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230618213250.694110-5-beanhuo@iokpp.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun 18-06-23 23:32:49, Bean Huo wrote: > From: Bean Huo > > Remove unnecessary check on the return value of block_commit_write(). > > Signed-off-by: Bean Huo Looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/ocfs2/file.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index efb09de4343d..39d8dbb26bb3 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -808,12 +808,7 @@ static int ocfs2_write_zero_page(struct inode *inode, u64 abs_from, > > > /* must not update i_size! */ > - ret = block_commit_write(page, block_start + 1, > - block_start + 1); > - if (ret < 0) > - mlog_errno(ret); > - else > - ret = 0; > + block_commit_write(page, block_start + 1, block_start + 1); > } > > /* > -- > 2.34.1 > -- Jan Kara SUSE Labs, CR