* [PATCH] ext4: Fix warning in blkdev_put()
@ 2023-06-22 16:51 Jan Kara
2023-06-23 5:57 ` Christoph Hellwig
2023-06-23 14:27 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kara @ 2023-06-22 16:51 UTC (permalink / raw)
To: Jens Axboe; +Cc: Christoph Hellwig, linux-ext4, linux-block, Jan Kara
ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which
triggers a warning there. Fix it.
Fixes: 2736e8eeb0cc ("block: use the holder as indication for exclusive opens")
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Jens, this is another fixup of the block device handling series sitting in
your tree.
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 53d74144ee34..d34b4eb90fe8 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1133,7 +1133,7 @@ static void ext4_blkdev_remove(struct ext4_sb_info *sbi)
struct block_device *bdev;
bdev = sbi->s_journal_bdev;
if (bdev) {
- blkdev_put(bdev, sbi->s_es);
+ blkdev_put(bdev, sbi->s_sb);
sbi->s_journal_bdev = NULL;
}
}
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ext4: Fix warning in blkdev_put()
2023-06-22 16:51 [PATCH] ext4: Fix warning in blkdev_put() Jan Kara
@ 2023-06-23 5:57 ` Christoph Hellwig
2023-06-23 14:27 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-06-23 5:57 UTC (permalink / raw)
To: Jan Kara; +Cc: Jens Axboe, Christoph Hellwig, linux-ext4, linux-block
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: Fix warning in blkdev_put()
2023-06-22 16:51 [PATCH] ext4: Fix warning in blkdev_put() Jan Kara
2023-06-23 5:57 ` Christoph Hellwig
@ 2023-06-23 14:27 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2023-06-23 14:27 UTC (permalink / raw)
To: Jan Kara; +Cc: Christoph Hellwig, linux-ext4, linux-block
On Thu, 22 Jun 2023 18:51:07 +0200, Jan Kara wrote:
> ext4_blkdev_remove() passes a wrong holder pointer to blkdev_put() which
> triggers a warning there. Fix it.
>
>
Applied, thanks!
[1/1] ext4: Fix warning in blkdev_put()
commit: a42fb5a75ccc37dfd69aa9bde5ba2866e802ff3c
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-23 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-22 16:51 [PATCH] ext4: Fix warning in blkdev_put() Jan Kara
2023-06-23 5:57 ` Christoph Hellwig
2023-06-23 14:27 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox