From: Bean Huo <beanhuo@iokpp.de>
To: viro@zeniv.linux.org.uk, brauner@kernel.org,
akpm@linux-foundation.org, jack@suse.cz, jack@suse.com,
tytso@mit.edu, adilger.kernel@dilger.ca, mark@fasheh.com,
jlbec@evilplan.org, joseph.qi@linux.alibaba.com,
willy@infradead.org, hch@infradead.org
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com,
beanhuo@micron.com
Subject: [RESEND PATCH v3 1/2] fs/buffer: clean up block_commit_write
Date: Mon, 26 Jun 2023 07:55:17 +0200 [thread overview]
Message-ID: <20230626055518.842392-2-beanhuo@iokpp.de> (raw)
In-Reply-To: <20230626055518.842392-1-beanhuo@iokpp.de>
From: Bean Huo <beanhuo@micron.com>
Originally inode is used to get blksize, after commit 45bce8f3e343
("fs/buffer.c: make block-size be per-page and protected by the page lock"),
__block_commit_write no longer uses this parameter inode.
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
fs/buffer.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index bd091329026c..50821dfb02f7 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2180,8 +2180,7 @@ int __block_write_begin(struct page *page, loff_t pos, unsigned len,
}
EXPORT_SYMBOL(__block_write_begin);
-static int __block_commit_write(struct inode *inode, struct folio *folio,
- size_t from, size_t to)
+static int __block_commit_write(struct folio *folio, size_t from, size_t to)
{
size_t block_start, block_end;
bool partial = false;
@@ -2277,7 +2276,7 @@ int block_write_end(struct file *file, struct address_space *mapping,
flush_dcache_folio(folio);
/* This could be a short (even 0-length) commit */
- __block_commit_write(inode, folio, start, start + copied);
+ __block_commit_write(folio, start, start + copied);
return copied;
}
@@ -2601,8 +2600,7 @@ EXPORT_SYMBOL(cont_write_begin);
int block_commit_write(struct page *page, unsigned from, unsigned to)
{
struct folio *folio = page_folio(page);
- struct inode *inode = folio->mapping->host;
- __block_commit_write(inode, folio, from, to);
+ __block_commit_write(folio, from, to);
return 0;
}
EXPORT_SYMBOL(block_commit_write);
@@ -2650,7 +2648,7 @@ int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
ret = __block_write_begin_int(folio, 0, end, get_block, NULL);
if (!ret)
- ret = __block_commit_write(inode, folio, 0, end);
+ ret = __block_commit_write(folio, 0, end);
if (unlikely(ret < 0))
goto out_unlock;
--
2.34.1
next prev parent reply other threads:[~2023-06-26 5:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 5:55 [RESEND PATCH v3 0/2] clean up block_commit_write Bean Huo
2023-06-26 5:55 ` Bean Huo [this message]
2023-06-26 7:55 ` [RESEND PATCH v3 1/2] fs/buffer: " Christoph Hellwig
2023-06-26 12:21 ` Matthew Wilcox
2023-06-26 13:41 ` Jan Kara
2023-06-26 5:55 ` [RESEND PATCH v3 2/2] fs: convert block_commit_write to return void Bean Huo
2023-06-26 7:55 ` Christoph Hellwig
2023-06-26 12:21 ` Matthew Wilcox
2023-06-26 12:26 ` [RESEND PATCH v3 0/2] clean up block_commit_write Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626055518.842392-2-beanhuo@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=beanhuo@micron.com \
--cc=brauner@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jlbec@evilplan.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).