Re: [PATCH v2 1/7] fs: Expose name under lookup to d_revalidate hook

Eric Biggers
2023-07-14T04:40:34Z

Hi Gabriel,

On Fri, Apr 21, 2023 at 08:03:04PM -0400, Gabriel Krisman Bertazi wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> Negative dentries support on case-insensitive ext4/f2fs will require
> access to the name under lookup to ensure it matches the dentry. This
> adds an optional new flavor of cached dentry revalidation hook to expose
> this extra parameter.
>
> I'm fine with extending d_revalidate instead of adding a new hook, if
> it is considered cleaner and the approach is accepted. I wrote a new
> hook to simplify reviewing.
>
> Reviewed-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> ---
> fs/dcache.c | 2 +-
> fs/namei.c | 23 ++++++++++++++---------
> include/linux/dcache.h | 1 +
> 3 files changed, 16 insertions(+), 10 deletions(-)

Documentation/filesystems/vfs.rst and Documentation/filesystems/locking.rst need
to be updated to document d_revalidate_name.

- Eric