From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A54EB64DC for ; Fri, 14 Jul 2023 05:55:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234924AbjGNFz0 (ORCPT ); Fri, 14 Jul 2023 01:55:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231972AbjGNFzV (ORCPT ); Fri, 14 Jul 2023 01:55:21 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81C1A2123; Thu, 13 Jul 2023 22:55:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13E1D61C2A; Fri, 14 Jul 2023 05:55:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EC76C433C7; Fri, 14 Jul 2023 05:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689314119; bh=IXG6OKn01yJj0TE1xVyNQVVP2cgIJ84xsyC/CW0XIaU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lNSPH9QfHOdM9FO2SngD10EMxHIkKS12TAD6XmT2erE4WSzUHeNZqG1g7ORyq9Ptc Wc7RRfwHvx/wbR5WolW+1AXcbpMN09Y3E/WXLvIdB34yAaMhs9YktbrqvSGTCKTKKl 6XZuOTEeIQsVog29Cz2aPr0e50H4Qxk7DlNn/9O6OZdN2w9+USiaxuK1FjyuX7Mowp VOJpP2p+PuN9wgFUJhrU4aTJbs5cFsg0224yfp8ayO73ubM67xA4jKtUDGoFT824fK Dq6P8F3ZmDt6Rwle9l0TAQQZE7eH5nZHHj29VmmGWjvMa7nTKF8WD/A8tvxWoW927/ zeswo3tOfNpuQ== Date: Thu, 13 Jul 2023 22:55:17 -0700 From: Eric Biggers To: Gabriel Krisman Bertazi Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, tytso@mit.edu, jaegeuk@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 2/7] fs: Add DCACHE_CASEFOLD_LOOKUP flag Message-ID: <20230714055517.GG913@sol.localdomain> References: <20230422000310.1802-1-krisman@suse.de> <20230422000310.1802-3-krisman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230422000310.1802-3-krisman@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Apr 21, 2023 at 08:03:05PM -0400, Gabriel Krisman Bertazi wrote: > @@ -209,6 +209,7 @@ struct dentry_operations { > #define DCACHE_FALLTHRU 0x01000000 /* Fall through to lower layer */ > #define DCACHE_NOKEY_NAME 0x02000000 /* Encrypted name encoded without key */ > #define DCACHE_OP_REAL 0x04000000 > +#define DCACHE_CASEFOLD_LOOKUP 0x08000000 /* Dentry comes from a casefold directory */ > > #define DCACHE_PAR_LOOKUP 0x10000000 /* being looked up (with parent locked shared) */ > #define DCACHE_DENTRY_CURSOR 0x20000000 The first time I read DCACHE_CASEFOLD_LOOKUP, I got the wrong impression, since it uses _LOOKUP in a different way from DCACHE_PAR_LOOKUP. DCACHE_PAR_LOOKUP uses it to mean "dentry is currently being looked up", while DCACHE_CASEFOLD_LOOKUP uses it to mean "dentry *was* looked up". Maybe DCACHE_CASEFOLDED_NAME would be more logical? That would follow DCACHE_NOKEY_NAME. (Also CASEFOLD => CASEFOLDED would be logical, I think.) - Eric