Re: [PATCH 5.4 000/313] 5.4.251-rc1 review

Re: [PATCH 5.4 000/313] 5.4.251-rc1 review

[Naresh Kamboju]

On Tue, 25 Jul 2023 at 17:06, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.4.251 release.
> There are 313 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.251-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Following commit caused build failures on stable-rc 5.4 and 5.10.

ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.

fs/ext4/ioctl.c:595:7: error: incompatible pointer to integer
conversion assigning to 'int' from 'struct super_block *'
[-Wint-conversion]
                ret = freeze_bdev(sb->s_bdev);
                    ^ ~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

--
Linaro LKFT
https://lkft.linaro.org

Re: [PATCH 5.4 000/313] 5.4.251-rc1 review

[Harshit Mogalapalli]

Hi Greg,

On 25/07/23 8:16 pm, Naresh Kamboju wrote:
> On Tue, 25 Jul 2023 at 17:06, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.4.251 release.
>> There are 313 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.251-rc1.gz
>> or in the git tree and branch at:
>>          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
> 
> Following commit caused build failures on stable-rc 5.4 and 5.10.
> 
> ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
> commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.
> 
> fs/ext4/ioctl.c:595:7: error: incompatible pointer to integer
> conversion assigning to 'int' from 'struct super_block *'
> [-Wint-conversion]
>                  ret = freeze_bdev(sb->s_bdev);
>                      ^ ~~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.
> 

I have seen this error too in 5.4.y build.

Just more information about this.

In 5.4.y:
struct super_block *freeze_bdev(struct block_device *bdev)
{
	...
}

In 5.15.y
int freeze_bdev(struct block_device *bdev)
{
	...
}

This changed in this commit which is in 5.11-rc1,(not in 5.4.y and 5.10.y)
Commit info:
   commit-id              : 040f04bd2e825f1d80b14a0e0ac3d830339eb779
   subject          : fs: simplify freeze_bdev/thaw_bdev


Thanks,
Harshit


> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> --
> Linaro LKFT
> https://lkft.linaro.org

Re: [PATCH 5.4 000/313] 5.4.251-rc1 review

[Greg Kroah-Hartman]

On Tue, Jul 25, 2023 at 08:48:03PM +0530, Harshit Mogalapalli wrote:
> Hi Greg,
> 
> On 25/07/23 8:16 pm, Naresh Kamboju wrote:
> > On Tue, 25 Jul 2023 at 17:06, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > 
> > > This is the start of the stable review cycle for the 5.4.251 release.
> > > There are 313 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > > 
> > > Responses should be made by Thu, 27 Jul 2023 10:44:26 +0000.
> > > Anything received after that time might be too late.
> > > 
> > > The whole patch series can be found in one patch at:
> > >          https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.251-rc1.gz
> > > or in the git tree and branch at:
> > >          git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > > and the diffstat can be found below.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Following commit caused build failures on stable-rc 5.4 and 5.10.
> > 
> > ext4: fix to check return value of freeze_bdev() in ext4_shutdown()
> > commit c4d13222afd8a64bf11bc7ec68645496ee8b54b9 upstream.
> > 
> > fs/ext4/ioctl.c:595:7: error: incompatible pointer to integer
> > conversion assigning to 'int' from 'struct super_block *'
> > [-Wint-conversion]
> >                  ret = freeze_bdev(sb->s_bdev);
> >                      ^ ~~~~~~~~~~~~~~~~~~~~~~~
> > 1 error generated.
> > 
> 
> I have seen this error too in 5.4.y build.
> 
> Just more information about this.
> 
> In 5.4.y:
> struct super_block *freeze_bdev(struct block_device *bdev)
> {
> 	...
> }
> 
> In 5.15.y
> int freeze_bdev(struct block_device *bdev)
> {
> 	...
> }
> 
> This changed in this commit which is in 5.11-rc1,(not in 5.4.y and 5.10.y)
> Commit info:
>   commit-id              : 040f04bd2e825f1d80b14a0e0ac3d830339eb779
>   subject          : fs: simplify freeze_bdev/thaw_bdev
> 
> 
> Thanks,
> Harshit

Thanks, will go drop this as well.

greg k-h