From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32B8C001DE for ; Mon, 31 Jul 2023 14:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232734AbjGaOoX (ORCPT ); Mon, 31 Jul 2023 10:44:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231411AbjGaOoW (ORCPT ); Mon, 31 Jul 2023 10:44:22 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC4B711B; Mon, 31 Jul 2023 07:44:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6B6E41F74C; Mon, 31 Jul 2023 14:44:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1690814659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dwho/MXbKRpCcua51Z6iAvWEEmHSGnN+iX9Rx/4iTvQ=; b=0svLKFvtUSXdOMe4RMJpVPTb3f9Ry/fD5sEBlrbrD5YhzJQ6c2vjRQQZImP7VH7kaZ1MNS bJI5OjbDXBEf6HgQ6/qORvSFX3g5S4hA5UdvUBgjs60+svGjVVTKEntNQVBq5V2czHVJMo 7S41KSIWnWyB7pxk4pdofRl8Knp+4Zc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1690814659; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dwho/MXbKRpCcua51Z6iAvWEEmHSGnN+iX9Rx/4iTvQ=; b=7R1W4UVHwOh8+aMtjfABCnpQDlobxxPR/6Pq768T5Krbct0KHwUju7bRrrMOSpENSYBTv8 OXytdgw8nabTm7CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5BCCD133F7; Mon, 31 Jul 2023 14:44:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OQNtFsPIx2S3XwAAMHmgww (envelope-from ); Mon, 31 Jul 2023 14:44:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E4896A069C; Mon, 31 Jul 2023 16:44:18 +0200 (CEST) Date: Mon, 31 Jul 2023 16:44:18 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , David Sterba , linux-fsdevel@vger.kernel.org, Pankaj Raghav , Konstantin Komarov , ntfs3@lists.linux.dev, Theodore Tso , Jan Kara , linux-ext4@vger.kernel.org Subject: Re: [PATCH 4/7] migrate: Use folio_set_bh() instead of set_bh_page() Message-ID: <20230731144418.xksm5ieabi6licom@quack3> References: <20230713035512.4139457-1-willy@infradead.org> <20230713035512.4139457-5-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230713035512.4139457-5-willy@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu 13-07-23 04:55:09, Matthew Wilcox (Oracle) wrote: > This function was converted before folio_set_bh() existed. Catch > up to the new API. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index af8557d78549..1363053894ce 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -773,7 +773,7 @@ static int __buffer_migrate_folio(struct address_space *mapping, > > bh = head; > do { > - set_bh_page(bh, &dst->page, bh_offset(bh)); > + folio_set_bh(bh, dst, bh_offset(bh)); > bh = bh->b_this_page; > } while (bh != head); > > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR