Re: [PATCH 06/12] fs: use the super_block as holder when mounting file systems

Jan Kara
2023-08-03T13:38:43Z

On Thu 03-08-23 13:51:31, Jan Kara wrote:
> On Wed 02-08-23 17:41:25, Christoph Hellwig wrote:
> > The file system type is not a very useful holder as it doesn't allow us
> > to go back to the actual file system instance. Pass the super_block instead
> > which is useful when passed back to the file system driver.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Nice, this is what I also wanted to eventually do :). Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>

As a side note, after this patch we can also remove bdev->bd_super and
transition the two real users (mark_buffer_write_io_error() and two places
in ocfs2) to use bd_holder. Ext4 also uses bd_super but there it is really
pointless as we have the superblock directly available in that function
anyway.

Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR