From: Liu Song <liusong@linux.alibaba.com>
To: adilger.kernel@dilger.ca, tytso@mit.edu, jack@suse.cz
Cc: liusong@linux.alibaba.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com
Subject: [PATCH] ext4: do not mark inode dirty which is already dirtied under append-write scenario
Date: Sun, 6 Aug 2023 11:12:17 +0800 [thread overview]
Message-ID: <20230806031217.13962-1-liusong@linux.alibaba.com> (raw)
In-Reply-To: <20230711034256.72651-1-liusong@linux.alibaba.com>
Hi,
Any comments on this? Considering the most extreme scenario
where a file is appended with only one byte each time,
"jbd2_journal_dirty_metadata" will be executed because i_size
has changed. Therefore, it is better to update raw_inode's size
after the writeback is completed, which can also ensure the
consistency of metadata and data, and obtain better performance
benefits in high-frequency append write scenarios.
Thanks
next prev parent reply other threads:[~2023-08-06 3:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 3:42 [PATCH] ext4: do not mark inode dirty which is already dirtied under append-write scenario Liu Song
2023-08-06 3:12 ` Liu Song [this message]
2023-08-09 12:25 ` Jan Kara
2023-08-10 6:59 ` Liu Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230806031217.13962-1-liusong@linux.alibaba.com \
--to=liusong@linux.alibaba.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox