From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C42AEC41513 for ; Wed, 16 Aug 2023 15:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344264AbjHPPyC (ORCPT ); Wed, 16 Aug 2023 11:54:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344445AbjHPPx5 (ORCPT ); Wed, 16 Aug 2023 11:53:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5FEDE52; Wed, 16 Aug 2023 08:53:55 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A23FC2189D; Wed, 16 Aug 2023 15:53:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1692201234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cS0o+o2UXMYju9CQYo6U7MKGEYtjqVHUZjdZNl8z6Y8=; b=Pi5tCwC/LN8E7q8RbwOtlHWbBKanHKet9PKL6glbDDZQTTwiWugz9n4JGvPt9d3wP3pllG t7thtPjzOUF+h3IzB2Nmw0/SuDnDB7iMfhbajd/qaUXC0ZVhhgpwgSIPy+sCrWhEDIG2QK cDhZ7Cu1sDA3/8YoW9ZAF+44ZqBURFw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1692201234; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cS0o+o2UXMYju9CQYo6U7MKGEYtjqVHUZjdZNl8z6Y8=; b=yFGTJ9XRtnvdvIxx9cZtkmOS4JGFDzvn9I9mqLL58LJXed0MNhzk6SGai59hWLgudFo/GW xcKt4TBLh2nV8BCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9345D133F2; Wed, 16 Aug 2023 15:53:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id l4y0IxLx3GTTJQAAMHmgww (envelope-from ); Wed, 16 Aug 2023 15:53:54 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 0B444A0769; Wed, 16 Aug 2023 17:53:54 +0200 (CEST) Date: Wed, 16 Aug 2023 17:53:54 +0200 From: Jan Kara To: Ye Bin Cc: jack@suse.cz, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] ext2: fix race between setxattr and write back Message-ID: <20230816155354.5dkicbptvrgcvnhy@quack3> References: <20230815112612.221145-1-yebin10@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230815112612.221145-1-yebin10@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue 15-08-23 19:26:08, Ye Bin wrote: > Diff v2 vs v1: > 1. Do not use reservation window when allocate block for xattr. > 2. Remove BUG() in ext2_try_to_allocate_with_rsv(). Thanks! I did't a few smaller spelling fixups on commit but otherwise the patches look good so I've added them to my tree. Honza > > Ye Bin (4): > ext2: remove ext2_new_block() > ext2: introduce flag argument for ext2_new_blocks() > ext2: fix race between setxattr and write back > ext2: dump current reservation window info > > fs/ext2/balloc.c | 32 +++++++++++++++++--------------- > fs/ext2/ext2.h | 8 ++++++-- > fs/ext2/inode.c | 2 +- > fs/ext2/xattr.c | 4 +++- > 4 files changed, 27 insertions(+), 19 deletions(-) > > -- > 2.31.1 > -- Jan Kara SUSE Labs, CR