From: "Theodore Ts'o" <tytso@mit.edu>
To: Fengnan Chang <changfengnan@bytedance.com>
Cc: adilger.kernel@dilger.ca, guoqing.jiang@linux.dev,
linux-ext4@vger.kernel.org,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [External] Re: [PATCH v3] ext4: improve trim efficiency
Date: Fri, 18 Aug 2023 12:55:40 -0400 [thread overview]
Message-ID: <20230818165540.GC3515079@mit.edu> (raw)
In-Reply-To: <CAPFOzZvwvSioyiCW8K7sDpzB7Grq==5-9i-wODGKw0E_4DFaPQ@mail.gmail.com>
On Fri, Aug 18, 2023 at 03:14:34PM +0800, Fengnan Chang wrote:
> If we move the allocation and initialization the ext4_free_data
> structure to ext4_try_to_trim_range, we need move
> ext4_lock_group too, because we can't do alloc memory when
> hold lock in ioctl context.
> How about just remove ext4_trim_extent, and do all work in
> ext4_try_to_trim_range? it will be easier to read.
Yes, agreed.
- Ted
prev parent reply other threads:[~2023-08-18 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 12:18 [PATCH v3] ext4: improve trim efficiency Fengnan Chang
2023-07-31 2:26 ` Guoqing Jiang
2023-07-31 12:52 ` [External] " Fengnan Chang
2023-08-09 8:20 ` Fengnan Chang
2023-08-18 3:43 ` Theodore Ts'o
2023-08-18 7:14 ` [External] " Fengnan Chang
2023-08-18 16:55 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818165540.GC3515079@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=changfengnan@bytedance.com \
--cc=guoqing.jiang@linux.dev \
--cc=linux-ext4@vger.kernel.org \
--cc=oliver.sang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).