[PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

[PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

[Theodore Ts'o]

Kernels with the commit "ext4: add correct group descriptors and
reserved GDT blocks to system zone" will refuse to mount the corrupted
file system constructed by this test.  So in order to perform the
test, we need to disable the block_validity checks.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/ext4/059 | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/ext4/059 b/tests/ext4/059
index 4230bde92..e4af77f1e 100755
--- a/tests/ext4/059
+++ b/tests/ext4/059
@@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
 $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
 	grep "Reserved GDT blocks"
 
+# Kernels with the commit "ext4: add correct group descriptors and
+# reserved GDT blocks to system zone" will refuse to mount the file
+# system due to block_validity checks; so disable block_validity.
+MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
+
 _scratch_mount
 
 # Expect no crash from this resize operation
-- 
2.31.0

Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

[Baokun Li]

Hi Zorro,

Could you pick up this patch?
This test case has been failing in the mainline for a while now.

Thanks,
Baokun

On 2023/8/23 22:56, Theodore Ts'o wrote:
> Kernels with the commit "ext4: add correct group descriptors and
> reserved GDT blocks to system zone" will refuse to mount the corrupted
> file system constructed by this test.  So in order to perform the
> test, we need to disable the block_validity checks.
>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Looks good to me, thanks for the patch!

Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com>

> ---
>   tests/ext4/059 | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tests/ext4/059 b/tests/ext4/059
> index 4230bde92..e4af77f1e 100755
> --- a/tests/ext4/059
> +++ b/tests/ext4/059
> @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
>   $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
>   	grep "Reserved GDT blocks"
>   
> +# Kernels with the commit "ext4: add correct group descriptors and
> +# reserved GDT blocks to system zone" will refuse to mount the file
> +# system due to block_validity checks; so disable block_validity.
> +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
> +
>   _scratch_mount
>   
>   # Expect no crash from this resize operation


-- 
With Best Regards,
Baokun Li

Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

[Zorro Lang]

On Thu, Jun 13, 2024 at 10:09:44AM +0800, Baokun Li wrote:
> Hi Zorro,
> 
> Could you pick up this patch?
> This test case has been failing in the mainline for a while now.

Sorry I just noticed this patch, looks like it was not sent to fstests@.
Sure, I'll merge it, thanks for CC me :)

Thanks,
Zorro

> 
> Thanks,
> Baokun
> 
> On 2023/8/23 22:56, Theodore Ts'o wrote:
> > Kernels with the commit "ext4: add correct group descriptors and
> > reserved GDT blocks to system zone" will refuse to mount the corrupted
> > file system constructed by this test.  So in order to perform the
> > test, we need to disable the block_validity checks.
> > 
> > Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> 
> Looks good to me, thanks for the patch!
> 
> Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com>
> 
> > ---
> >   tests/ext4/059 | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/tests/ext4/059 b/tests/ext4/059
> > index 4230bde92..e4af77f1e 100755
> > --- a/tests/ext4/059
> > +++ b/tests/ext4/059
> > @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
> >   $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
> >   	grep "Reserved GDT blocks"
> > +# Kernels with the commit "ext4: add correct group descriptors and
> > +# reserved GDT blocks to system zone" will refuse to mount the file
> > +# system due to block_validity checks; so disable block_validity.
> > +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
> > +
> >   _scratch_mount
> >   # Expect no crash from this resize operation
> 
> 
> -- 
> With Best Regards,
> Baokun Li
> 

Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

[Baokun Li]

On 2024/6/22 0:36, Zorro Lang wrote:
> On Thu, Jun 13, 2024 at 10:09:44AM +0800, Baokun Li wrote:
>> Hi Zorro,
>>
>> Could you pick up this patch?
>> This test case has been failing in the mainline for a while now.
> Sorry I just noticed this patch, looks like it was not sent to fstests@.
> Sure, I'll merge it, thanks for CC me :)

Thanks for merging it!

Seeing your reply I just noticed that the address of the fstests mail
list was misspelled.

Cheers,
Baokun

>
> Thanks,
> Zorro
>
>> Thanks,
>> Baokun
>>
>> On 2023/8/23 22:56, Theodore Ts'o wrote:
>>> Kernels with the commit "ext4: add correct group descriptors and
>>> reserved GDT blocks to system zone" will refuse to mount the corrupted
>>> file system constructed by this test.  So in order to perform the
>>> test, we need to disable the block_validity checks.
>>>
>>> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
>> Looks good to me, thanks for the patch!
>>
>> Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com>
>>
>>> ---
>>>    tests/ext4/059 | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/tests/ext4/059 b/tests/ext4/059
>>> index 4230bde92..e4af77f1e 100755
>>> --- a/tests/ext4/059
>>> +++ b/tests/ext4/059
>>> @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
>>>    $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
>>>    	grep "Reserved GDT blocks"
>>> +# Kernels with the commit "ext4: add correct group descriptors and
>>> +# reserved GDT blocks to system zone" will refuse to mount the file
>>> +# system due to block_validity checks; so disable block_validity.
>>> +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
>>> +
>>>    _scratch_mount
>>>    # Expect no crash from this resize operation
>>>