* [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system @ 2023-08-23 14:56 Theodore Ts'o 2024-06-13 2:09 ` Baokun Li 0 siblings, 1 reply; 4+ messages in thread From: Theodore Ts'o @ 2023-08-23 14:56 UTC (permalink / raw) To: linux-fstests; +Cc: Ext4 Developers List, Theodore Ts'o Kernels with the commit "ext4: add correct group descriptors and reserved GDT blocks to system zone" will refuse to mount the corrupted file system constructed by this test. So in order to perform the test, we need to disable the block_validity checks. Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- tests/ext4/059 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/ext4/059 b/tests/ext4/059 index 4230bde92..e4af77f1e 100755 --- a/tests/ext4/059 +++ b/tests/ext4/059 @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \ $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \ grep "Reserved GDT blocks" +# Kernels with the commit "ext4: add correct group descriptors and +# reserved GDT blocks to system zone" will refuse to mount the file +# system due to block_validity checks; so disable block_validity. +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity" + _scratch_mount # Expect no crash from this resize operation -- 2.31.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system 2023-08-23 14:56 [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system Theodore Ts'o @ 2024-06-13 2:09 ` Baokun Li 2024-06-21 16:36 ` Zorro Lang 0 siblings, 1 reply; 4+ messages in thread From: Baokun Li @ 2024-06-13 2:09 UTC (permalink / raw) To: zlang, Theodore Ts'o Cc: Ext4 Developers List, linux-fstests, 杨二坤 Hi Zorro, Could you pick up this patch? This test case has been failing in the mainline for a while now. Thanks, Baokun On 2023/8/23 22:56, Theodore Ts'o wrote: > Kernels with the commit "ext4: add correct group descriptors and > reserved GDT blocks to system zone" will refuse to mount the corrupted > file system constructed by this test. So in order to perform the > test, we need to disable the block_validity checks. > > Signed-off-by: Theodore Ts'o <tytso@mit.edu> Looks good to me, thanks for the patch! Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com> > --- > tests/ext4/059 | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/ext4/059 b/tests/ext4/059 > index 4230bde92..e4af77f1e 100755 > --- a/tests/ext4/059 > +++ b/tests/ext4/059 > @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \ > $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \ > grep "Reserved GDT blocks" > > +# Kernels with the commit "ext4: add correct group descriptors and > +# reserved GDT blocks to system zone" will refuse to mount the file > +# system due to block_validity checks; so disable block_validity. > +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity" > + > _scratch_mount > > # Expect no crash from this resize operation -- With Best Regards, Baokun Li ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system 2024-06-13 2:09 ` Baokun Li @ 2024-06-21 16:36 ` Zorro Lang 2024-06-22 2:31 ` Baokun Li 0 siblings, 1 reply; 4+ messages in thread From: Zorro Lang @ 2024-06-21 16:36 UTC (permalink / raw) To: Baokun Li Cc: Theodore Ts'o, Ext4 Developers List, linux-fstests, 杨二坤, fstests On Thu, Jun 13, 2024 at 10:09:44AM +0800, Baokun Li wrote: > Hi Zorro, > > Could you pick up this patch? > This test case has been failing in the mainline for a while now. Sorry I just noticed this patch, looks like it was not sent to fstests@. Sure, I'll merge it, thanks for CC me :) Thanks, Zorro > > Thanks, > Baokun > > On 2023/8/23 22:56, Theodore Ts'o wrote: > > Kernels with the commit "ext4: add correct group descriptors and > > reserved GDT blocks to system zone" will refuse to mount the corrupted > > file system constructed by this test. So in order to perform the > > test, we need to disable the block_validity checks. > > > > Signed-off-by: Theodore Ts'o <tytso@mit.edu> > > Looks good to me, thanks for the patch! > > Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com> > > > --- > > tests/ext4/059 | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tests/ext4/059 b/tests/ext4/059 > > index 4230bde92..e4af77f1e 100755 > > --- a/tests/ext4/059 > > +++ b/tests/ext4/059 > > @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \ > > $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \ > > grep "Reserved GDT blocks" > > +# Kernels with the commit "ext4: add correct group descriptors and > > +# reserved GDT blocks to system zone" will refuse to mount the file > > +# system due to block_validity checks; so disable block_validity. > > +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity" > > + > > _scratch_mount > > # Expect no crash from this resize operation > > > -- > With Best Regards, > Baokun Li > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system 2024-06-21 16:36 ` Zorro Lang @ 2024-06-22 2:31 ` Baokun Li 0 siblings, 0 replies; 4+ messages in thread From: Baokun Li @ 2024-06-22 2:31 UTC (permalink / raw) To: Zorro Lang Cc: Theodore Ts'o, Ext4 Developers List, fstests, yangerkun, Baokun Li On 2024/6/22 0:36, Zorro Lang wrote: > On Thu, Jun 13, 2024 at 10:09:44AM +0800, Baokun Li wrote: >> Hi Zorro, >> >> Could you pick up this patch? >> This test case has been failing in the mainline for a while now. > Sorry I just noticed this patch, looks like it was not sent to fstests@. > Sure, I'll merge it, thanks for CC me :) Thanks for merging it! Seeing your reply I just noticed that the address of the fstests mail list was misspelled. Cheers, Baokun > > Thanks, > Zorro > >> Thanks, >> Baokun >> >> On 2023/8/23 22:56, Theodore Ts'o wrote: >>> Kernels with the commit "ext4: add correct group descriptors and >>> reserved GDT blocks to system zone" will refuse to mount the corrupted >>> file system constructed by this test. So in order to perform the >>> test, we need to disable the block_validity checks. >>> >>> Signed-off-by: Theodore Ts'o <tytso@mit.edu> >> Looks good to me, thanks for the patch! >> >> Reviewed-and-tested-by: Baokun Li <libaokun1@huawei.com> >> >>> --- >>> tests/ext4/059 | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/tests/ext4/059 b/tests/ext4/059 >>> index 4230bde92..e4af77f1e 100755 >>> --- a/tests/ext4/059 >>> +++ b/tests/ext4/059 >>> @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \ >>> $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \ >>> grep "Reserved GDT blocks" >>> +# Kernels with the commit "ext4: add correct group descriptors and >>> +# reserved GDT blocks to system zone" will refuse to mount the file >>> +# system due to block_validity checks; so disable block_validity. >>> +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity" >>> + >>> _scratch_mount >>> # Expect no crash from this resize operation >>> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-22 2:51 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-23 14:56 [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system Theodore Ts'o 2024-06-13 2:09 ` Baokun Li 2024-06-21 16:36 ` Zorro Lang 2024-06-22 2:31 ` Baokun Li
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).