public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org,
	Vitaliy Kuznetsov <vk.en.mail@gmail.com>,
	adilger@dilger.ca
Subject: Re: [PATCH v2] ext4: Add periodic superblock update check
Date: Fri, 25 Aug 2023 14:34:22 +0200	[thread overview]
Message-ID: <20230825123422.xiex6inglvlqtayd@quack3> (raw)
In-Reply-To: <169285281338.4146427.4994363470834118959.b4-ty@mit.edu>

On Thu 24-08-23 00:53:44, Theodore Ts'o wrote:
> 
> On Thu, 10 Aug 2023 18:38:52 +0400, Vitaliy Kuznetsov wrote:
> > This patch introduces a mechanism to periodically check and update
> > the superblock within the ext4 file system. The main purpose of this
> > patch is to keep the disk superblock up to date. The update will be
> > performed if more than one hour has passed since the last update, and
> > if more than 16MB of data have been written to disk.
> > 
> > This check and update is performed within the ext4_journal_commit_callback
> > function, ensuring that the superblock is written while the disk is
> > active, rather than based on a timer that may trigger during disk idle
> > periods.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/1] ext4: Add periodic superblock update check
>       commit: 58d85f2e88c97c69c869cae6c6bdd1af32936146

Coverity is telling me that this commit is adding uninitialized variable
access to call_notify_err and it seems to be correct... call_notify_err
needs to be initialized to 0.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2023-08-25 12:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 12:25 [PATCH] ext4: Add periodic superblock update check Vitaliy Kuznetsov
2023-08-02 21:18 ` Andreas Dilger
2023-08-04 20:58 ` Theodore Ts'o
2023-08-10 14:38 ` [PATCH v2] " Vitaliy Kuznetsov
2023-08-24  4:53   ` Theodore Ts'o
2023-08-25 12:34     ` Jan Kara [this message]
2023-08-26 19:58     ` [PATCH v3] " vk.en.mail
2023-08-28 11:48       ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825123422.xiex6inglvlqtayd@quack3 \
    --to=jack@suse.cz \
    --cc=adilger@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=vk.en.mail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox