Re: [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

Gabriel Krisman Bertazi
2023-08-21T18:55:06Z

Christian Brauner <brauner@kernel.org> writes:

> On Thu, Aug 17, 2023 at 10:06:58AM -0700, Eric Biggers wrote:
>> On Wed, Aug 16, 2023 at 01:07:54AM -0400, Gabriel Krisman Bertazi wrote:
>> > Hi,
>> >
>> > This is v6 of the negative dentry on case-insensitive directories.
>> > Thanks Eric for the review of the last iteration. This version
>> > drops the patch to expose the helper to check casefolding directories,
>> > since it is not necessary in ecryptfs and it might be going away. It
>> > also addresses some documentation details, fix a build bot error and
>> > simplifies the commit messages. See the changelog in each patch for
>> > more details.
>> >
>> > Thanks,
>> >
>> > ---
>> >
>> > Gabriel Krisman Bertazi (9):
>> > ecryptfs: Reject casefold directory inodes
>> > 9p: Split ->weak_revalidate from ->revalidate
>> > fs: Expose name under lookup to d_revalidate hooks
>> > fs: Add DCACHE_CASEFOLDED_NAME flag
>> > libfs: Validate negative dentries in case-insensitive directories
>> > libfs: Chain encryption checks after case-insensitive revalidation
>> > libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops
>> > ext4: Enable negative dentries on case-insensitive lookup
>> > f2fs: Enable negative dentries on case-insensitive lookup
>> >
>>
>> Looks good,
>>
>> Reviewed-by: Eric Biggers <ebiggers@google.com>
>
> Thanks! We're a bit too late for v6.6 with this given that this hasn't
> even been in -next. So this will be up for v6.7.

Targeting 6.7 is fine by me. will you pick it up through the vfs tree? I
prefer it goes through there since it mostly touches vfs.

--
Gabriel Krisman Bertazi