From: yangerkun <yangerkun@huawei.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH] ext4: return 0 when ext4_get_group_info failed in __mb_check_buddy
Date: Tue, 2 Jan 2024 19:20:12 +0800 [thread overview]
Message-ID: <20240102112012.672260-1-yangerkun@huawei.com> (raw)
The return value for __mb_check_buddy should be a integer. Found this by
code review.
Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail")
Signed-off-by: yangerkun <yangerkun@huawei.com>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index d72b5e3c92ec..55c70a1b445a 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -758,7 +758,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file,
grp = ext4_get_group_info(sb, e4b->bd_group);
if (!grp)
- return NULL;
+ return 0;
list_for_each(cur, &grp->bb_prealloc_list) {
ext4_group_t groupnr;
struct ext4_prealloc_space *pa;
--
2.39.2
next reply other threads:[~2024-01-02 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 11:20 yangerkun [this message]
2024-01-02 12:17 ` [PATCH] ext4: return 0 when ext4_get_group_info failed in __mb_check_buddy Kemeng Shi
2024-01-02 12:33 ` yangerkun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102112012.672260-1-yangerkun@huawei.com \
--to=yangerkun@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox