From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] ext4: remove unused ext4_allocation_context::ac_groups_considered
Date: Tue, 2 Jan 2024 14:03:44 +0100 [thread overview]
Message-ID: <20240102130344.a3tbpf7sftmrfjbw@quack3> (raw)
In-Reply-To: <20231125161143.3945726-5-shikemeng@huaweicloud.com>
On Sun 26-11-23 00:11:39, Kemeng Shi wrote:
> Remove unused ext4_allocation_context::ac_groups_considered
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Hum, indeed. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/mballoc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
> index d7aeb5da7..56938532b 100644
> --- a/fs/ext4/mballoc.h
> +++ b/fs/ext4/mballoc.h
> @@ -192,7 +192,6 @@ struct ext4_allocation_context {
> */
> ext4_grpblk_t ac_orig_goal_len;
>
> - __u32 ac_groups_considered;
> __u32 ac_flags; /* allocation hints */
> __u16 ac_groups_scanned;
> __u16 ac_groups_linear_remaining;
> --
> 2.30.0
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-01-02 13:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 16:11 [PATCH 0/8] Some random cleanups to mballoc Kemeng Shi
2023-11-25 16:11 ` [PATCH 1/8] ext4: remove unused return value of __mb_check_buddy Kemeng Shi
2024-01-02 13:00 ` Jan Kara
2023-11-25 16:11 ` [PATCH 2/8] ext4: remove unused parameter group in ext4_mb_choose_next_group_*() Kemeng Shi
2024-01-02 13:01 ` Jan Kara
2023-11-25 16:11 ` [PATCH 3/8] ext4: remove unneeded return value of ext4_mb_release_context Kemeng Shi
2024-01-02 13:02 ` Jan Kara
2023-11-25 16:11 ` [PATCH 4/8] ext4: remove unused ext4_allocation_context::ac_groups_considered Kemeng Shi
2024-01-02 13:03 ` Jan Kara [this message]
2023-11-25 16:11 ` [PATCH 5/8] ext4: remove unused return value of ext4_mb_release Kemeng Shi
2024-01-02 13:04 ` Jan Kara
2023-11-25 16:11 ` [PATCH 6/8] ext4: remove unused return value of ext4_mb_release_inode_pa Kemeng Shi
2024-01-02 13:05 ` Jan Kara
2023-11-25 16:11 ` [PATCH 7/8] ext4: remove unused return value of ext4_mb_release_group_pa Kemeng Shi
2024-01-02 13:06 ` Jan Kara
2023-11-25 16:11 ` [PATCH 8/8] ext4: remove unnecessary parameter "needed" in ext4_discard_preallocations Kemeng Shi
2024-01-02 13:10 ` Jan Kara
2024-01-03 1:27 ` Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240102130344.a3tbpf7sftmrfjbw@quack3 \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox