From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A924F20B; Tue, 16 Jan 2024 01:08:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PLaEvu6W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1A8FC433C7; Tue, 16 Jan 2024 01:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705367335; bh=ZDtFRIb/fpAfkJQDm1UN7mcyjgdEaqh/FiiUHas/HhA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PLaEvu6Waf/Eh9z5Ji1DHMYtrYroRfk8qiXcqbIZqb00WGO3+h6sA8eNGSt+fWYYK tMXpfWr/x56Sm3iWE+5SzdKOE4gdxzvgh/fx/97s2cvAH/aX31o9uXX3KUC1sZGNxc 78jAYiJBylulsBw30AQnF8HJOAVCknCe+fkPEgvcgLhHYZiQLlccpI2tKQx1M7Vc+p mrfTlF8oADXrWFE/LvTN7fdjf6tlDyHunQ286KgcbWf7YX/kJ/GgU2UFyy5zDrdjyb FE5DJ/G+mpL5oxKr5ztFV4nqmBDJ0baHv7X/nJADboYUt95eiyfvKVbMiE04Qa9MUh vjN4jdJh3dwOg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Baokun Li , Jan Kara , Theodore Ts'o , Sasha Levin , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 7/8] ext4: remove unnecessary check from alloc_flex_gd() Date: Mon, 15 Jan 2024 20:08:37 -0500 Message-ID: <20240116010842.219925-7-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116010842.219925-1-sashal@kernel.org> References: <20240116010842.219925-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.305 Content-Transfer-Encoding: 8bit From: Baokun Li [ Upstream commit b099eb87de105cf07cad731ded6fb40b2675108b ] In commit 967ac8af4475 ("ext4: fix potential integer overflow in alloc_flex_gd()"), an overflow check is added to alloc_flex_gd() to prevent the allocated memory from being smaller than expected due to the overflow. However, after kmalloc() is replaced with kmalloc_array() in commit 6da2ec56059c ("treewide: kmalloc() -> kmalloc_array()"), the kmalloc_array() function has an overflow check, so the above problem will not occur. Therefore, the extra check is removed. Signed-off-by: Baokun Li Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20231023013057.2117948-3-libaokun1@huawei.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/resize.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index 2d27d4e06f7b..d9a8742873c9 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -245,10 +245,7 @@ static struct ext4_new_flex_group_data *alloc_flex_gd(unsigned int flexbg_size) if (flex_gd == NULL) goto out3; - if (flexbg_size >= UINT_MAX / sizeof(struct ext4_new_group_data)) - goto out2; flex_gd->count = flexbg_size; - flex_gd->groups = kmalloc_array(flexbg_size, sizeof(struct ext4_new_group_data), GFP_NOFS); -- 2.43.0