From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] fs: Introduce buffered_write_operations
Date: Thu, 1 Feb 2024 05:42:46 +0100 [thread overview]
Message-ID: <20240201044246.GA14117@lst.de> (raw)
In-Reply-To: <ZbsfuaANd4DIVb4w@casper.infradead.org>
On Thu, Feb 01, 2024 at 04:36:09AM +0000, Matthew Wilcox wrote:
> +static struct folio *iomap_write_begin(struct iomap_iter *iter, loff_t pos,
> + size_t len)
>
> with corresponding changes. Again, ends up looking slightly cleaner.
iomap also really needs some tweaks to the naming in the area as a
__foo function calling foo as the default is horrible. I'll take a
look at your patches and can add that on top.
> f2fs also doesn't seem terribly objectional; passing rpages between
> begin & end.
>
> ocfs2 is passing a ocfs2_write_ctxt between the two.
Well, it might be the intended purpose, but as-is it is horribly
inefficient - they need to do a dynamic allocation for every
page they iterate over. So all of them are candidates for an
iterator model that does this allocation once per write.
But maybe this isn't the time to deal with that and we should just leave
it in place.
next prev parent reply other threads:[~2024-02-01 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 5:54 [PATCH 0/3] Start moving write_begin/write_end out of aops Matthew Wilcox (Oracle)
2024-01-30 5:54 ` [PATCH 1/3] fs: Introduce buffered_write_operations Matthew Wilcox (Oracle)
2024-01-30 8:12 ` Christoph Hellwig
2024-02-01 4:36 ` Matthew Wilcox
2024-02-01 4:42 ` Christoph Hellwig [this message]
2024-02-02 19:54 ` Matthew Wilcox
2024-01-31 3:14 ` kernel test robot
2024-01-30 5:54 ` [PATCH 2/3] fs: Supply optional buffered_write_operations in buffer.c Matthew Wilcox (Oracle)
2024-01-30 5:54 ` [PATCH 3/3] ext4: Convert to buffered_write_operations Matthew Wilcox (Oracle)
2024-01-30 6:13 ` Matthew Wilcox
2024-01-30 8:13 ` Christoph Hellwig
2024-02-01 15:12 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201044246.GA14117@lst.de \
--to=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).