public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Baokun Li <libaokun1@huawei.com>
To: <linux-ext4@vger.kernel.org>
Cc: <tytso@mit.edu>, <adilger.kernel@dilger.ca>, <jack@suse.cz>,
	<ritesh.list@gmail.com>, <ojaswin@linux.ibm.com>,
	<adobriyan@gmail.com>, <linux-kernel@vger.kernel.org>,
	<yi.zhang@huawei.com>, <yangerkun@huawei.com>,
	<libaokun1@huawei.com>, <stable@kernel.org>
Subject: [PATCH v2 7/9] ext4: set type of ac_groups_linear_remaining to __u32 to avoid overflow
Date: Tue, 27 Feb 2024 17:11:46 +0800	[thread overview]
Message-ID: <20240227091148.178435-8-libaokun1@huawei.com> (raw)
In-Reply-To: <20240227091148.178435-1-libaokun1@huawei.com>

Now ac_groups_linear_remaining is of type __u16 and s_mb_max_linear_groups
is of type unsigned int, so an overflow occurs when setting a value above
65535 through the mb_max_linear_groups sysfs interface. Therefore, the
type of ac_groups_linear_remaining is set to __u32 to avoid overflow.

Fixes: 196e402adf2e ("ext4: improve cr 0 / cr 1 group scanning")
CC: stable@kernel.org
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/mballoc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index 56938532b4ce..7bfc5fb5a128 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -193,8 +193,8 @@ struct ext4_allocation_context {
 	ext4_grpblk_t	ac_orig_goal_len;
 
 	__u32 ac_flags;		/* allocation hints */
+	__u32 ac_groups_linear_remaining;
 	__u16 ac_groups_scanned;
-	__u16 ac_groups_linear_remaining;
 	__u16 ac_found;
 	__u16 ac_cX_found[EXT4_MB_NUM_CRS];
 	__u16 ac_tail;
-- 
2.31.1


  parent reply	other threads:[~2024-02-27  9:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27  9:11 [PATCH v2 0/9] ext4: avoid sysfs variables overflow causing BUG_ON/SOOB Baokun Li
2024-02-27  9:11 ` [PATCH v2 1/9] ext4: avoid overflow when setting values via sysfs Baokun Li
2024-03-14 10:16   ` Jan Kara
2024-02-27  9:11 ` [PATCH v2 2/9] ext4: refactor out ext4_generic_attr_store() Baokun Li
2024-03-14 10:18   ` Jan Kara
2024-02-27  9:11 ` [PATCH v2 3/9] ext4: refactor out ext4_generic_attr_show() Baokun Li
2024-02-27  9:11 ` [PATCH v2 4/9] ext4: fix slab-out-of-bounds in ext4_mb_find_good_group_avg_frag_lists() Baokun Li
2024-03-14 10:30   ` Jan Kara
2024-03-14 11:24     ` Baokun Li
2024-03-14 12:00       ` Jan Kara
2024-03-14 12:37         ` Baokun Li
2024-03-14 12:50           ` Jan Kara
2024-03-14 13:47             ` Baokun Li
2024-02-27  9:11 ` [PATCH v2 5/9] ext4: add new attr pointer attr_mb_order Baokun Li
2024-03-14 10:32   ` Jan Kara
2024-02-27  9:11 ` [PATCH v2 6/9] ext4: add positive int attr pointer to avoid sysfs variables overflow Baokun Li
2024-03-14 10:33   ` Jan Kara
2024-02-27  9:11 ` Baokun Li [this message]
2024-02-27  9:11 ` [PATCH v2 8/9] ext4: set the type of max_zeroout to unsigned int to avoid overflow Baokun Li
2024-03-14 10:35   ` Jan Kara
2024-02-27  9:11 ` [PATCH v2 9/9] ext4: clean up s_mb_rb_lock to fix build warnings with C=1 Baokun Li
2024-03-14 10:36   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240227091148.178435-8-libaokun1@huawei.com \
    --to=libaokun1@huawei.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=adobriyan@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=stable@kernel.org \
    --cc=tytso@mit.edu \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox