From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC32F69317; Fri, 1 Mar 2024 08:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709281559; cv=none; b=Fbag1IHwRAqvMFnhyuov0csgLBYzK7ataZ3SdbkqZ/U//wgqUNrbrLn8HGqfmbn3OEyGJYqVxyPBkA/lGWMnebbaonaSCOwiWZLPJ+N2sLCcBLweTC0Zg7ZuztI5zgZ7qhfbEEHzrY4p+iJ33xckBLFZboReJE7GadgWY5vTafw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709281559; c=relaxed/simple; bh=B5b9ibF+22tppvs5WWOhUY+3DjIPr1oOBhj58DmZtbE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QNLGsos6Wk2B1E7PCOxnNa7y5vKf5jNcovMFlfUsqlcTTJt0ZdrU1Lb8TzVJydQ2aSXr0TGZrIgNMwfDVTVatoDLaHkGU9EIDy3S40Zee0isHPW4IHeCJlfFMsiBZl0EYdJ8EtGCLLKaCwVHhsC5bVlaH+dZOT/zsFjbAgeKLz8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OxWIk5EJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OxWIk5EJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03281C433F1; Fri, 1 Mar 2024 08:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709281559; bh=B5b9ibF+22tppvs5WWOhUY+3DjIPr1oOBhj58DmZtbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OxWIk5EJjuXl1oHzZNiHNOKTSMhcclIzMwYzBocd5pqOCLDWgIryGu1UWsPwm7VNH qdxzYMa5hnw8Vcn7EH6DkBJoIiyJFxNyawPUS+1V6JBvyvkX4JYBFF16kE1aM7nCxI 07MHuXIf+ULQlbcDyE5Eju7bluK6bUp8ReZk3oxVTXJ05SbO0xHwOC6/EWCvI1Igbe zoMLNoWwxvmeKL81Xq8P0JYR90A/itsrMDIKkxmQBhrF8T4+01niWgrO+WZ7RecTvW 5ElvfBNVOrvi8DIGEx788rG0YlRiUedr4EGPXsVAVYPpsO2RDCwGYKPLPcWmJW/pu3 oEaDu5w2f2jbg== Date: Fri, 1 Mar 2024 09:25:54 +0100 From: Christian Brauner To: Kemeng Shi Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, daniel.diaz@linaro.org, linux@roeck-us.net Subject: Re: [PATCH 1/2] ext4: alloc test super block from sget Message-ID: <20240301-neuland-zoomen-4152b34c6fba@brauner> References: <20240301120816.22581-1-shikemeng@huaweicloud.com> <20240301120816.22581-2-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240301120816.22581-2-shikemeng@huaweicloud.com> On Fri, Mar 01, 2024 at 08:08:15PM +0800, Kemeng Shi wrote: > This fix the oops in ext4 unit test which is cuased by NULL sb.s_user_ns > as following: > <4>[ 14.344565] map_id_range_down (kernel/user_namespace.c:318) > <4>[ 14.345378] make_kuid (kernel/user_namespace.c:415) > <4>[ 14.345998] inode_init_always (include/linux/fs.h:1375 fs/inode.c:174) > <4>[ 14.346696] alloc_inode (fs/inode.c:268) > <4>[ 14.347353] new_inode_pseudo (fs/inode.c:1007) > <4>[ 14.348016] new_inode (fs/inode.c:1033) > <4>[ 14.348644] ext4_mb_init (fs/ext4/mballoc.c:3404 fs/ext4/mballoc.c:3719) > <4>[ 14.349312] mbt_kunit_init (fs/ext4/mballoc-test.c:57 > fs/ext4/mballoc-test.c:314) > <4>[ 14.349983] kunit_try_run_case (lib/kunit/test.c:388 lib/kunit/test.c:443) > <4>[ 14.350696] kunit_generic_run_threadfn_adapter (lib/kunit/try-catch.c:30) > <4>[ 14.351530] kthread (kernel/kthread.c:388) > <4>[ 14.352168] ret_from_fork (arch/arm64/kernel/entry.S:861) > <0>[ 14.353385] Code: 52808004 b8236ae7 72be5e44 b90004c4 (38e368a1) > > Alloc test super block from sget to properly initialize test super block > to fix the issue. > > Signed-off-by: Kemeng Shi > Reported-by: Linux Kernel Functional Testing > Reported-by: Guenter Roeck > --- > fs/ext4/mballoc-test.c | 46 ++++++++++++++++++++++++++++-------------- > 1 file changed, 31 insertions(+), 15 deletions(-) > > diff --git a/fs/ext4/mballoc-test.c b/fs/ext4/mballoc-test.c > index 12d0b22cabe1..1da52bbf4599 100644 > --- a/fs/ext4/mballoc-test.c > +++ b/fs/ext4/mballoc-test.c > @@ -21,16 +21,27 @@ struct mbt_ctx { > }; > > struct mbt_ext4_super_block { > - struct super_block sb; > + struct ext4_super_block es; > + struct ext4_sb_info sbi; > struct mbt_ctx mbt_ctx; > }; > > -#define MBT_CTX(_sb) (&(container_of((_sb), struct mbt_ext4_super_block, sb)->mbt_ctx)) > +#define MBT_SB(_sb) (container_of((_sb)->s_fs_info, struct mbt_ext4_super_block, sbi)) > +#define MBT_CTX(_sb) (&MBT_SB(_sb)->mbt_ctx) > #define MBT_GRP_CTX(_sb, _group) (&MBT_CTX(_sb)->grp_ctx[_group]) > > static const struct super_operations mbt_sops = { > }; > > +static void mbt_kill_sb(struct super_block *sb) > +{ > +} > + > +static struct file_system_type mbt_fs_type = { > + .name = "mballoc test", > + .kill_sb = mbt_kill_sb, > +}; > + > static int mbt_mb_init(struct super_block *sb) > { > int ret; > @@ -72,43 +83,48 @@ static void mbt_mb_release(struct super_block *sb) > kfree(sb->s_bdev); > } > > +static int mbt_set(struct super_block *sb, void *data) > +{ > + return 0; > +} > + > static struct super_block *mbt_ext4_alloc_super_block(void) > { > - struct ext4_super_block *es = kzalloc(sizeof(*es), GFP_KERNEL); > - struct ext4_sb_info *sbi = kzalloc(sizeof(*sbi), GFP_KERNEL); > struct mbt_ext4_super_block *fsb = kzalloc(sizeof(*fsb), GFP_KERNEL); > + struct super_block *sb = sget(&mbt_fs_type, NULL, mbt_set, 0, NULL); > + struct ext4_sb_info *sbi; > > - if (fsb == NULL || sbi == NULL || es == NULL) > + if (fsb == NULL || sb == NULL) sget() returns error pointer on failure. So you should check for IS_ERR(sb).