Re: [PATCH 3/3] overlay: fix mount parameters check for empty values

Christian Brauner
2024-03-01T13:37:31Z

On Thu, Feb 29, 2024 at 04:30:10PM +0000, Luis Henriques wrote:
> Now that parameters that have the flag 'fs_param_can_be_empty' set and
> their value is NULL are handled as 'flag' type, we need to properly check
> for empty (NULL) values.
>
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
> fs/overlayfs/params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
> index 112b4b12f825..09428af6abc5 100644
> --- a/fs/overlayfs/params.c
> +++ b/fs/overlayfs/params.c
> @@ -441,7 +441,7 @@ static int ovl_parse_param_lowerdir(const char *name, struct fs_context *fc)
> /* drop all existing lower layers */
> ovl_reset_lowerdirs(ctx);
>
> - if (!*name)
> + if (!name)

Same comment/qestion as on ext4 patch.