From: Jan Kara <jack@suse.cz>
To: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: tytso@mit.edu, jack@suse.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] jbd2: avoid memleak in jbd2_journal_write_metadata_buffer
Date: Sun, 12 May 2024 12:09:30 +0200 [thread overview]
Message-ID: <20240512100930.7p5pylbazn5etw7k@quack3> (raw)
In-Reply-To: <20240506141801.1165315-2-shikemeng@huaweicloud.com>
On Mon 06-05-24 22:17:53, Kemeng Shi wrote:
> The new_bh is from alloc_buffer_head, we should call free_buffer_head to
> free it in error case.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/journal.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index b6c114c11b97..207b24e12ce9 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -399,6 +399,7 @@ int jbd2_journal_write_metadata_buffer(transaction_t *transaction,
> tmp = jbd2_alloc(bh_in->b_size, GFP_NOFS);
> if (!tmp) {
> brelse(new_bh);
> + free_buffer_head(new_bh);
> return -ENOMEM;
> }
> spin_lock(&jh_in->b_state_lock);
> --
> 2.30.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2024-05-13 13:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 14:17 [PATCH 0/9] A fix and some cleanups to jbd2 Kemeng Shi
2024-05-06 14:17 ` [PATCH 1/9] jbd2: avoid memleak in jbd2_journal_write_metadata_buffer Kemeng Shi
2024-05-06 14:42 ` Zhang Yi
2024-05-12 10:09 ` Jan Kara [this message]
2024-05-06 14:17 ` [PATCH 2/9] jbd2: remove unused return info from jbd2_journal_write_metadata_buffer Kemeng Shi
2024-05-07 11:51 ` Zhang Yi
2024-05-08 1:42 ` Kemeng Shi
2024-05-12 10:14 ` Jan Kara
2024-05-06 14:17 ` [PATCH 3/9] jbd2: remove unnedded "need_copy_out" in jbd2_journal_write_metadata_buffer Kemeng Shi
2024-05-07 12:28 ` Zhang Yi
2024-05-12 11:06 ` Jan Kara
2024-05-06 14:17 ` [PATCH 4/9] jbd2: move repeat tag around to remove a repeat check of b_frozen_data Kemeng Shi
2024-05-07 12:41 ` Zhang Yi
2024-05-08 1:45 ` Kemeng Shi
2024-05-06 14:17 ` [PATCH 5/9] jbd2: remove unneeded kmap to do escape in jbd2_journal_write_metadata_buffer Kemeng Shi
2024-05-07 13:11 ` Zhang Yi
2024-05-12 11:13 ` Jan Kara
2024-05-06 14:17 ` [PATCH 6/9] jbd2: use bh_in instead of jh2bh(jh_in) to simplify code Kemeng Shi
2024-05-07 13:13 ` Zhang Yi
2024-05-12 11:14 ` Jan Kara
2024-05-06 14:17 ` [PATCH 7/9] jbd2: remove dead equality check of j_commit_[sequence/request] in kjournald2 Kemeng Shi
2024-05-09 11:51 ` Zhang Yi
2024-05-12 11:22 ` Jan Kara
2024-05-06 14:18 ` [PATCH 8/9] jbd2: remove dead check of JBD2_UNMOUNT " Kemeng Shi
2024-05-09 12:02 ` Zhang Yi
2024-05-12 11:24 ` Jan Kara
2024-05-06 14:18 ` [PATCH 9/9] jbd2: remove unnecessary "should_sleep" " Kemeng Shi
2024-05-09 12:09 ` Zhang Yi
2024-05-12 11:26 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240512100930.7p5pylbazn5etw7k@quack3 \
--to=jack@suse.cz \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox