public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Lizhi Xu <lizhi.xu@windriver.com>
To: <ebiggers@kernel.org>
Cc: <adilger.kernel@dilger.ca>, <coreteam@netfilter.org>,
	<davem@davemloft.net>, <fw@strlen.de>, <jaegeuk@kernel.org>,
	<kadlec@netfilter.org>, <kuba@kernel.org>,
	<linux-ext4@vger.kernel.org>, <linux-fscrypt@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <lizhi.xu@windriver.com>,
	<netdev@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
	<pablo@netfilter.org>,
	<syzbot+340581ba9dceb7e06fb3@syzkaller.appspotmail.com>,
	<syzkaller-bugs@googlegroups.com>, <tytso@mit.edu>
Subject: [PATCH V3] ext4: check hash version and filesystem casefolded consistent
Date: Fri, 31 May 2024 16:56:47 +0800	[thread overview]
Message-ID: <20240531085647.2918240-1-lizhi.xu@windriver.com> (raw)
In-Reply-To: <20240531033407.GB6505@sol.localdomain>

When mounting the ext4 filesystem, if the hash version and casefolded are not
consistent, exit the mounting.

Reported-by: syzbot+340581ba9dceb7e06fb3@syzkaller.appspotmail.com
Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>
---
 fs/ext4/super.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index c682fb927b64..c0036e3922c2 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -5262,6 +5262,9 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
 		goto failed_mount;
 
 	ext4_hash_info_init(sb);
+	if (es->s_def_hash_version == DX_HASH_SIPHASH && 
+	    !ext4_has_feature_casefold(sb))
+		goto failed_mount;
 
 	err = ext4_handle_clustersize(sb);
 	if (err)
-- 
2.43.0


  reply	other threads:[~2024-05-31  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240531010513.GA9629@sol.localdomain>
2024-05-31  3:30 ` [PATCH V2] ext4: add casefolded feature check before setup encrypted info Lizhi Xu
2024-05-31  3:34   ` Eric Biggers
2024-05-31  8:56     ` Lizhi Xu [this message]
2024-06-04  9:27       ` [PATCH V3] ext4: check hash version and filesystem casefolded consistent Dan Carpenter
2024-06-04  9:36         ` Lizhi Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240531085647.2918240-1-lizhi.xu@windriver.com \
    --to=lizhi.xu@windriver.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=ebiggers@kernel.org \
    --cc=fw@strlen.de \
    --cc=jaegeuk@kernel.org \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=syzbot+340581ba9dceb7e06fb3@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox