From: David Disseldorp <ddiss@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: Zorro Lang <zlang@kernel.org>,
fstests@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org
Subject: Re: mostly remove _supported_fs
Date: Mon, 24 Jun 2024 12:17:30 +1000 [thread overview]
Message-ID: <20240624121730.4d35b58a.ddiss@suse.de> (raw)
In-Reply-To: <20240623121103.974270-1-hch@lst.de>
On Sun, 23 Jun 2024 14:10:29 +0200, Christoph Hellwig wrote:
> Hi Zorro,
>
> this series improves generic/740 and then mostly removes _supported_fs
> as it's largely not needed.
>
> The exceptions are the negative matches, which should probably be
> replaced with a new _exclude_fs helper, and the test/ext4 directly
> which is also run by magic for ext2 and ext3. I'm not entirely sure
> what to do about it, but removing this magic and just adding small
> wrappers for ext2 and ext3 to run the ext4 tests would seem like
> the best idea to me.
This whole series looks good to me:
Reviewed-by: David Disseldorp <ddiss@suse.de>
There are many double-empty-lines following the patch 8/8 removals
(btrfs/014, btrfs/031, btrfs/192, btrfs/196, generic/004, etc.) but they
could be cleaned up on merge. Also, "# Modify as appropriate." would
make a good addition to your removal regex.
next prev parent reply other threads:[~2024-06-24 2:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 12:10 mostly remove _supported_fs Christoph Hellwig
2024-06-23 12:10 ` [PATCH 1/8] remove support for ext4dev Christoph Hellwig
2024-06-23 12:10 ` [PATCH 2/8] generic/740: clean up handling of mkfs options Christoph Hellwig
2024-06-23 12:10 ` [PATCH 3/8] generic/740: pass the --quick option to mkfs.ntfs Christoph Hellwig
2024-06-23 12:10 ` [PATCH 4/8] generic/740: skip jffs2 as foreign fs earlier Christoph Hellwig
2024-06-23 12:10 ` [PATCH 5/8] generic/740: enable by default Christoph Hellwig
2024-06-24 16:16 ` Darrick J. Wong
2024-06-25 3:50 ` Theodore Ts'o
2024-06-25 6:00 ` Christoph Hellwig
2024-06-25 20:05 ` Theodore Ts'o
2024-06-26 4:01 ` Christoph Hellwig
2024-06-23 12:10 ` [PATCH 6/8] generic/745: rework support fs checking Christoph Hellwig
2024-06-23 12:10 ` [PATCH 7/8] generic/746: clean up fs support Christoph Hellwig
2024-06-23 12:10 ` [PATCH 8/8] remove spurious _supported_fs calls Christoph Hellwig
2024-06-24 2:17 ` David Disseldorp [this message]
2024-06-24 16:17 ` mostly remove _supported_fs Darrick J. Wong
2024-07-10 6:16 ` Christoph Hellwig
2024-07-11 13:16 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240624121730.4d35b58a.ddiss@suse.de \
--to=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox