From: "Theodore Ts'o" <tytso@mit.edu>
To: "wangjianjian (C)" <wangjianjian3@huawei.com>
Cc: Wang Jianjian <wangjianjian0@foxmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] jbd2: Add a comment for incorrect tag size
Date: Thu, 27 Jun 2024 09:31:56 -0400 [thread overview]
Message-ID: <20240627133156.GC412555@mit.edu> (raw)
In-Reply-To: <0c296005-c607-431d-a696-b5b165c83856@huawei.com>
On Thu, Jun 20, 2024 at 11:19:30AM +0800, wangjianjian (C) wrote:
> On 2024/6/20 7:36, Theodore Ts'o wrote:
> > bd2: fix descriptor block size handling errors with journal_csum
> > in 2016 --- a full eight years ago. So it's probably not worth adding
> the comment at this point.
>
> Thanks for detailed information, but is it better to put it in document in
> case any other one confuse about this when read code.
The comment would probably make things more confusing, since there's a
much larger context involving the fact that csum_v2 is an obsolete
format that in practice is never used. Sure, we could make the
comment even more verbose, but perhaps it would be better to simply
completely remove csum_v1 and csum_v2 from the code. That will
probably make the code even more simpler to read.
Cheers,
- Ted
next prev parent reply other threads:[~2024-06-27 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 13:36 [PATCH] jbd2: Add a comment for incorrect tag size Wang Jianjian
2024-06-19 23:36 ` Theodore Ts'o
2024-06-20 3:19 ` wangjianjian (C)
2024-06-27 13:31 ` Theodore Ts'o [this message]
2024-06-28 2:15 ` wangjianjian (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627133156.GC412555@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=wangjianjian0@foxmail.com \
--cc=wangjianjian3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox