* Linux 6.10 regression resulting in a crash when using an ext4 filesystem
@ 2024-07-21 21:10 Artem S. Tashkinov
2024-07-22 4:19 ` Darrick J. Wong
0 siblings, 1 reply; 6+ messages in thread
From: Artem S. Tashkinov @ 2024-07-21 21:10 UTC (permalink / raw)
To: Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer
Hello,
There are now two bug reports containing very similar if not exactly the
same backtraces.
https://bugzilla.kernel.org/show_bug.cgi?id=219072
https://bugzilla.kernel.org/show_bug.cgi?id=219078
Theodore, please take a look.
Might not be necesserily ext4 related but I cannot tell.
------------[ cut here ]------------
strnlen: detected buffer overflow: 17 byte read of buffer size 16
WARNING: CPU: 3 PID: 1622 at lib/string_helpers.c:1029
__fortify_report+0x43/0x50
Modules linked in: rfcomm snd_seq_dummy snd_hrtimer snd_seq uhid cmac
algif_hash algif_skcipher af_alg bnep vfat fat amd_atl intel_rapl_msr
intel_rapl_common kvm_amd snd_hda_codec_realtek snd_hda_codec_generic
kvm ip6t_REJECT snd_hda_scodec_component snd_hda_codec_hdmi
nf_reject_ipv6 crct10dif_pclmul crc32_pclmul xt_hl snd_usb_audio
polyval_clmulni snd_hda_intel ip6t_rt polyval_generic snd_intel_dspcfg
gf128mul snd_usbmidi_lib snd_intel_sdw_acpi ghash_clmulni_intel
sha512_ssse3 snd_ump snd_hda_codec sha256_ssse3 snd_rawmidi sha1_ssse3
btusb snd_hda_core snd_seq_device aesni_intel btrtl mc snd_hwdep btintel
crypto_simd btbcm snd_pcm cryptd r8169 btmtk realtek snd_timer
mdio_devres rapl bluetooth snd wmi_bmof k10temp pcspkr ipt_REJECT ccp
i2c_piix4 libphy soundcore nf_reject_ipv4 xt_LOG rfkill nf_log_syslog
joydev mousedev nft_limit gpio_amdpt gpio_generic mac_hid lz4
lz4_compress xt_limit xt_addrtype xt_tcpudp xt_conntrack nf_conntrack
nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables libcrc32c tcp_bbr
winesync(OE) pkcs8_key_parser i2c_dev crypto_user dm_mod loop
nfnetlink zram ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2
hid_generic usbhid amdgpu video amdxcp i2c_algo_bit drm_ttm_helper ttm
drm_exec gpu_sched drm_suballoc_helper drm_buddy nvme drm_display_helper
nvme_core crc32c_intel cec xhci_pci xhci_pci_renesas nvme_auth wmi
CPU: 3 PID: 1622 Comm: KIO::WorkerThre Tainted: G OE
6.10.0-arch1-1 #1 3f70a25b32dbfb369f64430c352117d965bafd6c
Hardware name: Micro-Star International Co., Ltd MS-7C02/B450 TOMAHAWK
MAX (MS-7C02), BIOS 3.I0 10/14/2023
RIP: 0010:__fortify_report+0x43/0x50
Code: c1 83 e7 01 48 c7 c1 82 1a 45 8f 48 c7 c7 e8 49 4b 8f 48 8b 34 c5
e0 55 ed 8e 48 c7 c0 3d f7 44 8f 48 0f 44 c8 e8 7d 4b a3 ff <0f> 0b c3
cc cc cc cc 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90
RSP: 0018:ffffb4b09f7b3b68 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
PKRU: 55555554
Call Trace:
<TASK>
? __fortify_report+0x43/0x50
? __warn.cold+0x8e/0xe8
? __fortify_report+0x43/0x50
? report_bug+0xff/0x140
? console_unlock+0x84/0x130
? handle_bug+0x3c/0x80
? exc_invalid_op+0x17/0x70
? asm_exc_invalid_op+0x1a/0x20
? __fortify_report+0x43/0x50
? __fortify_report+0x43/0x50
__fortify_panic+0xd/0xf
__ext4_ioctl.cold+0x13/0x59 [ext4
2a94c00997ffaf4059189da5c3ba69455dc04edb]
? do_filp_open+0xc4/0x170
? __fdget_raw+0xa5/0xc0
? terminate_walk+0x61/0x100
__x64_sys_ioctl+0x94/0xd0
do_syscall_64+0x82/0x190
? from_kgid_munged+0x12/0x30
? cp_statx+0x19f/0x1e0
? do_statx+0x72/0xa0
? syscall_exit_to_user_mode+0x72/0x200
? do_syscall_64+0x8e/0x190
? do_user_addr_fault+0x36c/0x620
? exc_page_fault+0x81/0x190
entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x760ade31f13f
Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89
44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d
00 f0 ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00
RSP: 002b:0000760a5dfff310 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000760a5dfff560 RCX: 0000760ade31f13f
RDX: 0000760a5dfff390 RSI: 0000000081009431 RDI: 000000000000003e
RBP: 0000760a5dfff4b0 R08: 0000760a5dfff580 R09: 00007609e0007ae0
R10: 0000000000001000 R11: 0000000000000246 R12: 0000760a5dfff390
R13: 00007609e00135e0 R14: 0000760a5dfff540 R15: 0000000000010308
</TASK>
---[ end trace 0000000000000000 ]---
------------[ cut here ]------------
kernel BUG at lib/string_helpers.c:1037!
Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
CPU: 3 PID: 1622 Comm: KIO::WorkerThre Tainted: G W OE
6.10.0-arch1-1 #1 3f70a25b32dbfb369f64430c352117d965bafd6c
Hardware name: Micro-Star International Co., Ltd MS-7C02/B450 TOMAHAWK
MAX (MS-7C02), BIOS 3.I0 10/14/2023
RIP: 0010:__fortify_panic+0xd/0xf
Code: ff e8 87 03 00 00 e9 08 b8 89 ff 66 90 90 90 90 90 90 90 90 90 90
90 90 90 90 90 90 90 f3 0f 1e fa 40 0f b6 ff e8 b3 e2 89 ff <0f> 0b 48
8b 54 24 10 48 8b 74 24 08 4c 89 e9 48 c7 c7 99 27 42 8f
RSP: 0018:ffffb4b09f7b3b70 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
PKRU: 55555554
Call Trace:
<TASK>
? __die_body.cold+0x19/0x27
? die+0x2e/0x50
? do_trap+0xca/0x110
? do_error_trap+0x6a/0x90
? __fortify_panic+0xd/0xf
? exc_invalid_op+0x50/0x70
? __fortify_panic+0xd/0xf
? asm_exc_invalid_op+0x1a/0x20
? __fortify_panic+0xd/0xf
__ext4_ioctl.cold+0x13/0x59 [ext4
2a94c00997ffaf4059189da5c3ba69455dc04edb]
? do_filp_open+0xc4/0x170
? __fdget_raw+0xa5/0xc0
? terminate_walk+0x61/0x100
__x64_sys_ioctl+0x94/0xd0
do_syscall_64+0x82/0x190
? from_kgid_munged+0x12/0x30
? cp_statx+0x19f/0x1e0
? do_statx+0x72/0xa0
? syscall_exit_to_user_mode+0x72/0x200
? do_syscall_64+0x8e/0x190
? do_user_addr_fault+0x36c/0x620
? exc_page_fault+0x81/0x190
entry_SYSCALL_64_after_hwframe+0x76/0x7e
RIP: 0033:0x760ade31f13f
Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89
44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d
00 f0 ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00
RSP: 002b:0000760a5dfff310 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000760a5dfff560 RCX: 0000760ade31f13f
RDX: 0000760a5dfff390 RSI: 0000000081009431 RDI: 000000000000003e
RBP: 0000760a5dfff4b0 R08: 0000760a5dfff580 R09: 00007609e0007ae0
R10: 0000000000001000 R11: 0000000000000246 R12: 0000760a5dfff390
R13: 00007609e00135e0 R14: 0000760a5dfff540 R15: 0000000000010308
</TASK>
Modules linked in: rfcomm snd_seq_dummy snd_hrtimer snd_seq uhid cmac
algif_hash algif_skcipher af_alg bnep vfat fat amd_atl intel_rapl_msr
intel_rapl_common kvm_amd snd_hda_codec_realtek snd_hda_codec_generic
kvm ip6t_REJECT snd_hda_scodec_component snd_hda_codec_hdmi
nf_reject_ipv6 crct10dif_pclmul crc32_pclmul xt_hl snd_usb_audio
polyval_clmulni snd_hda_intel ip6t_rt polyval_generic snd_intel_dspcfg
gf128mul snd_usbmidi_lib snd_intel_sdw_acpi ghash_clmulni_intel
sha512_ssse3 snd_ump snd_hda_codec sha256_ssse3 snd_rawmidi sha1_ssse3
btusb snd_hda_core snd_seq_device aesni_intel btrtl mc snd_hwdep btintel
crypto_simd btbcm snd_pcm cryptd r8169 btmtk realtek snd_timer
mdio_devres rapl bluetooth snd wmi_bmof k10temp pcspkr ipt_REJECT ccp
i2c_piix4 libphy soundcore nf_reject_ipv4 xt_LOG rfkill nf_log_syslog
joydev mousedev nft_limit gpio_amdpt gpio_generic mac_hid lz4
lz4_compress xt_limit xt_addrtype xt_tcpudp xt_conntrack nf_conntrack
nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables libcrc32c tcp_bbr
winesync(OE) pkcs8_key_parser i2c_dev crypto_user dm_mod loop
nfnetlink zram ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2
hid_generic usbhid amdgpu video amdxcp i2c_algo_bit drm_ttm_helper ttm
drm_exec gpu_sched drm_suballoc_helper drm_buddy nvme drm_display_helper
nvme_core crc32c_intel cec xhci_pci xhci_pci_renesas nvme_auth wmi
---[ end trace 0000000000000000 ]---
RIP: 0010:__fortify_panic+0xd/0xf
Code: ff e8 87 03 00 00 e9 08 b8 89 ff 66 90 90 90 90 90 90 90 90 90 90
90 90 90 90 90 90 90 f3 0f 1e fa 40 0f b6 ff e8 b3 e2 89 ff <0f> 0b 48
8b 54 24 10 48 8b 74 24 08 4c 89 e9 48 c7 c7 99 27 42 8f
RSP: 0018:ffffb4b09f7b3b70 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
PKRU: 55555554
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
2024-07-21 21:10 Linux 6.10 regression resulting in a crash when using an ext4 filesystem Artem S. Tashkinov
@ 2024-07-22 4:19 ` Darrick J. Wong
2024-07-22 7:06 ` Kees Cook
0 siblings, 1 reply; 6+ messages in thread
From: Darrick J. Wong @ 2024-07-22 4:19 UTC (permalink / raw)
To: Artem S. Tashkinov
Cc: Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer,
justinstitt, keescook, linux-hardening
On Sun, Jul 21, 2024 at 09:10:59PM +0000, Artem S. Tashkinov wrote:
> Hello,
>
> There are now two bug reports containing very similar if not exactly the
> same backtraces.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=219072
> https://bugzilla.kernel.org/show_bug.cgi?id=219078
>
> Theodore, please take a look.
[adding everyone involved in 744a56389f739 ("ext4: replace deprecated
strncpy with alternatives") to cc]
Is strscpy_pad appropriate if the @src parameter itself is a fixed
length char[16] which isn't null terminated when the label itself is 16
chars long?
--D
> Might not be necesserily ext4 related but I cannot tell.
>
> ------------[ cut here ]------------
> strnlen: detected buffer overflow: 17 byte read of buffer size 16
> WARNING: CPU: 3 PID: 1622 at lib/string_helpers.c:1029
> __fortify_report+0x43/0x50
> Modules linked in: rfcomm snd_seq_dummy snd_hrtimer snd_seq uhid cmac
> algif_hash algif_skcipher af_alg bnep vfat fat amd_atl intel_rapl_msr
> intel_rapl_common kvm_amd snd_hda_codec_realtek snd_hda_codec_generic
> kvm ip6t_REJECT snd_hda_scodec_component snd_hda_codec_hdmi
> nf_reject_ipv6 crct10dif_pclmul crc32_pclmul xt_hl snd_usb_audio
> polyval_clmulni snd_hda_intel ip6t_rt polyval_generic snd_intel_dspcfg
> gf128mul snd_usbmidi_lib snd_intel_sdw_acpi ghash_clmulni_intel
> sha512_ssse3 snd_ump snd_hda_codec sha256_ssse3 snd_rawmidi sha1_ssse3
> btusb snd_hda_core snd_seq_device aesni_intel btrtl mc snd_hwdep btintel
> crypto_simd btbcm snd_pcm cryptd r8169 btmtk realtek snd_timer
> mdio_devres rapl bluetooth snd wmi_bmof k10temp pcspkr ipt_REJECT ccp
> i2c_piix4 libphy soundcore nf_reject_ipv4 xt_LOG rfkill nf_log_syslog
> joydev mousedev nft_limit gpio_amdpt gpio_generic mac_hid lz4
> lz4_compress xt_limit xt_addrtype xt_tcpudp xt_conntrack nf_conntrack
> nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables libcrc32c tcp_bbr
> winesync(OE) pkcs8_key_parser i2c_dev crypto_user dm_mod loop
> nfnetlink zram ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2
> hid_generic usbhid amdgpu video amdxcp i2c_algo_bit drm_ttm_helper ttm
> drm_exec gpu_sched drm_suballoc_helper drm_buddy nvme drm_display_helper
> nvme_core crc32c_intel cec xhci_pci xhci_pci_renesas nvme_auth wmi
> CPU: 3 PID: 1622 Comm: KIO::WorkerThre Tainted: G OE
> 6.10.0-arch1-1 #1 3f70a25b32dbfb369f64430c352117d965bafd6c
> Hardware name: Micro-Star International Co., Ltd MS-7C02/B450 TOMAHAWK
> MAX (MS-7C02), BIOS 3.I0 10/14/2023
> RIP: 0010:__fortify_report+0x43/0x50
> Code: c1 83 e7 01 48 c7 c1 82 1a 45 8f 48 c7 c7 e8 49 4b 8f 48 8b 34 c5
> e0 55 ed 8e 48 c7 c0 3d f7 44 8f 48 0f 44 c8 e8 7d 4b a3 ff <0f> 0b c3
> cc cc cc cc 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90
> RSP: 0018:ffffb4b09f7b3b68 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
> RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
> RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
> R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
> R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
> FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __fortify_report+0x43/0x50
> ? __warn.cold+0x8e/0xe8
> ? __fortify_report+0x43/0x50
> ? report_bug+0xff/0x140
> ? console_unlock+0x84/0x130
> ? handle_bug+0x3c/0x80
> ? exc_invalid_op+0x17/0x70
> ? asm_exc_invalid_op+0x1a/0x20
> ? __fortify_report+0x43/0x50
> ? __fortify_report+0x43/0x50
> __fortify_panic+0xd/0xf
> __ext4_ioctl.cold+0x13/0x59 [ext4
> 2a94c00997ffaf4059189da5c3ba69455dc04edb]
> ? do_filp_open+0xc4/0x170
> ? __fdget_raw+0xa5/0xc0
> ? terminate_walk+0x61/0x100
> __x64_sys_ioctl+0x94/0xd0
> do_syscall_64+0x82/0x190
> ? from_kgid_munged+0x12/0x30
> ? cp_statx+0x19f/0x1e0
> ? do_statx+0x72/0xa0
> ? syscall_exit_to_user_mode+0x72/0x200
> ? do_syscall_64+0x8e/0x190
> ? do_user_addr_fault+0x36c/0x620
> ? exc_page_fault+0x81/0x190
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> RIP: 0033:0x760ade31f13f
> Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89
> 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d
> 00 f0 ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00
> RSP: 002b:0000760a5dfff310 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 0000760a5dfff560 RCX: 0000760ade31f13f
> RDX: 0000760a5dfff390 RSI: 0000000081009431 RDI: 000000000000003e
> RBP: 0000760a5dfff4b0 R08: 0000760a5dfff580 R09: 00007609e0007ae0
> R10: 0000000000001000 R11: 0000000000000246 R12: 0000760a5dfff390
> R13: 00007609e00135e0 R14: 0000760a5dfff540 R15: 0000000000010308
> </TASK>
> ---[ end trace 0000000000000000 ]---
> ------------[ cut here ]------------
> kernel BUG at lib/string_helpers.c:1037!
> Oops: invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
> CPU: 3 PID: 1622 Comm: KIO::WorkerThre Tainted: G W OE
> 6.10.0-arch1-1 #1 3f70a25b32dbfb369f64430c352117d965bafd6c
> Hardware name: Micro-Star International Co., Ltd MS-7C02/B450 TOMAHAWK
> MAX (MS-7C02), BIOS 3.I0 10/14/2023
> RIP: 0010:__fortify_panic+0xd/0xf
> Code: ff e8 87 03 00 00 e9 08 b8 89 ff 66 90 90 90 90 90 90 90 90 90 90
> 90 90 90 90 90 90 90 f3 0f 1e fa 40 0f b6 ff e8 b3 e2 89 ff <0f> 0b 48
> 8b 54 24 10 48 8b 74 24 08 4c 89 e9 48 c7 c7 99 27 42 8f
> RSP: 0018:ffffb4b09f7b3b70 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
> RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
> RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
> R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
> R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
> FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
> PKRU: 55555554
> Call Trace:
> <TASK>
> ? __die_body.cold+0x19/0x27
> ? die+0x2e/0x50
> ? do_trap+0xca/0x110
> ? do_error_trap+0x6a/0x90
> ? __fortify_panic+0xd/0xf
> ? exc_invalid_op+0x50/0x70
> ? __fortify_panic+0xd/0xf
> ? asm_exc_invalid_op+0x1a/0x20
> ? __fortify_panic+0xd/0xf
> __ext4_ioctl.cold+0x13/0x59 [ext4
> 2a94c00997ffaf4059189da5c3ba69455dc04edb]
> ? do_filp_open+0xc4/0x170
> ? __fdget_raw+0xa5/0xc0
> ? terminate_walk+0x61/0x100
> __x64_sys_ioctl+0x94/0xd0
> do_syscall_64+0x82/0x190
> ? from_kgid_munged+0x12/0x30
> ? cp_statx+0x19f/0x1e0
> ? do_statx+0x72/0xa0
> ? syscall_exit_to_user_mode+0x72/0x200
> ? do_syscall_64+0x8e/0x190
> ? do_user_addr_fault+0x36c/0x620
> ? exc_page_fault+0x81/0x190
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> RIP: 0033:0x760ade31f13f
> Code: 00 48 89 44 24 18 31 c0 48 8d 44 24 60 c7 04 24 10 00 00 00 48 89
> 44 24 08 48 8d 44 24 20 48 89 44 24 10 b8 10 00 00 00 0f 05 <89> c2 3d
> 00 f0 ff ff 77 18 48 8b 44 24 18 64 48 2b 04 25 28 00 00
> RSP: 002b:0000760a5dfff310 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
> RAX: ffffffffffffffda RBX: 0000760a5dfff560 RCX: 0000760ade31f13f
> RDX: 0000760a5dfff390 RSI: 0000000081009431 RDI: 000000000000003e
> RBP: 0000760a5dfff4b0 R08: 0000760a5dfff580 R09: 00007609e0007ae0
> R10: 0000000000001000 R11: 0000000000000246 R12: 0000760a5dfff390
> R13: 00007609e00135e0 R14: 0000760a5dfff540 R15: 0000000000010308
> </TASK>
> Modules linked in: rfcomm snd_seq_dummy snd_hrtimer snd_seq uhid cmac
> algif_hash algif_skcipher af_alg bnep vfat fat amd_atl intel_rapl_msr
> intel_rapl_common kvm_amd snd_hda_codec_realtek snd_hda_codec_generic
> kvm ip6t_REJECT snd_hda_scodec_component snd_hda_codec_hdmi
> nf_reject_ipv6 crct10dif_pclmul crc32_pclmul xt_hl snd_usb_audio
> polyval_clmulni snd_hda_intel ip6t_rt polyval_generic snd_intel_dspcfg
> gf128mul snd_usbmidi_lib snd_intel_sdw_acpi ghash_clmulni_intel
> sha512_ssse3 snd_ump snd_hda_codec sha256_ssse3 snd_rawmidi sha1_ssse3
> btusb snd_hda_core snd_seq_device aesni_intel btrtl mc snd_hwdep btintel
> crypto_simd btbcm snd_pcm cryptd r8169 btmtk realtek snd_timer
> mdio_devres rapl bluetooth snd wmi_bmof k10temp pcspkr ipt_REJECT ccp
> i2c_piix4 libphy soundcore nf_reject_ipv4 xt_LOG rfkill nf_log_syslog
> joydev mousedev nft_limit gpio_amdpt gpio_generic mac_hid lz4
> lz4_compress xt_limit xt_addrtype xt_tcpudp xt_conntrack nf_conntrack
> nf_defrag_ipv6 nf_defrag_ipv4 nft_compat nf_tables libcrc32c tcp_bbr
> winesync(OE) pkcs8_key_parser i2c_dev crypto_user dm_mod loop
> nfnetlink zram ip_tables x_tables ext4 crc32c_generic crc16 mbcache jbd2
> hid_generic usbhid amdgpu video amdxcp i2c_algo_bit drm_ttm_helper ttm
> drm_exec gpu_sched drm_suballoc_helper drm_buddy nvme drm_display_helper
> nvme_core crc32c_intel cec xhci_pci xhci_pci_renesas nvme_auth wmi
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:__fortify_panic+0xd/0xf
> Code: ff e8 87 03 00 00 e9 08 b8 89 ff 66 90 90 90 90 90 90 90 90 90 90
> 90 90 90 90 90 90 90 f3 0f 1e fa 40 0f b6 ff e8 b3 e2 89 ff <0f> 0b 48
> 8b 54 24 10 48 8b 74 24 08 4c 89 e9 48 c7 c7 99 27 42 8f
> RSP: 0018:ffffb4b09f7b3b70 EFLAGS: 00010286
> RAX: 0000000000000000 RBX: ffff991a934c6000 RCX: 0000000000000027
> RDX: ffff99219eba19c8 RSI: 0000000000000001 RDI: ffff99219eba19c0
> RBP: ffffb4b09f7b3c38 R08: 0000000000000000 R09: ffffb4b09f7b39e8
> R10: ffffffff8fcb21e8 R11: 0000000000000003 R12: 0000760a5dfff390
> R13: ffff991a8a724af8 R14: ffff991aa4a3d478 R15: ffffffff8fd2a5a0
> FS: 0000760a5e0006c0(0000) GS:ffff99219eb80000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007609e0013810 CR3: 000000012cb70000 CR4: 0000000000f50ef0
> PKRU: 55555554
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
2024-07-22 4:19 ` Darrick J. Wong
@ 2024-07-22 7:06 ` Kees Cook
2024-07-23 4:11 ` Theodore Ts'o
0 siblings, 1 reply; 6+ messages in thread
From: Kees Cook @ 2024-07-22 7:06 UTC (permalink / raw)
To: Darrick J. Wong, Artem S. Tashkinov
Cc: Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer,
justinstitt, keescook, linux-hardening
On July 21, 2024 9:19:24 PM PDT, "Darrick J. Wong" <djwong@kernel.org> wrote:
>On Sun, Jul 21, 2024 at 09:10:59PM +0000, Artem S. Tashkinov wrote:
>> Hello,
>>
>> There are now two bug reports containing very similar if not exactly the
>> same backtraces.
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=219072
>> https://bugzilla.kernel.org/show_bug.cgi?id=219078
>>
>> Theodore, please take a look.
>
>[adding everyone involved in 744a56389f739 ("ext4: replace deprecated
>strncpy with alternatives") to cc]
>
>Is strscpy_pad appropriate if the @src parameter itself is a fixed
>length char[16] which isn't null terminated when the label itself is 16
>chars long?
Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
-Kees
--
Kees Cook
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
2024-07-22 7:06 ` Kees Cook
@ 2024-07-23 4:11 ` Theodore Ts'o
2024-07-23 10:04 ` Thorsten Leemhuis
0 siblings, 1 reply; 6+ messages in thread
From: Theodore Ts'o @ 2024-07-23 4:11 UTC (permalink / raw)
To: Kees Cook
Cc: Darrick J. Wong, Artem S. Tashkinov, Linux Kernel Mailing List,
linux-ext4, xcreativ, madeisbaer, justinstitt, keescook,
linux-hardening
On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
> >Is strscpy_pad appropriate if the @src parameter itself is a fixed
> >length char[16] which isn't null terminated when the label itself is 16
> >chars long?
>
> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
Yeah, sorry, I was on vacation for 3.5 weeks starting just before
Memorial day, and it took me a while to get caught up. Unfortunately,
I missed the bug in the strncpy extirpation patch, and it was't
something that our regression tests caught. (Sometimes, the
old/deprecated ways are just more reliable; all of ext4's strncpy()
calls were working and had been correct for decades. :-P )
Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be
making its way to -stable.
- Ted
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
2024-07-23 4:11 ` Theodore Ts'o
@ 2024-07-23 10:04 ` Thorsten Leemhuis
2024-07-23 11:14 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Thorsten Leemhuis @ 2024-07-23 10:04 UTC (permalink / raw)
To: Greg KH, stable@vger.kernel.org
Cc: Darrick J. Wong, Artem S. Tashkinov, Linux Kernel Mailing List,
linux-ext4, xcreativ, madeisbaer, justinstitt, keescook,
linux-hardening, Theodore Ts'o, Kees Cook,
Linux kernel regressions list
On 23.07.24 06:11, Theodore Ts'o wrote:
> On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
>>> Is strscpy_pad appropriate if the @src parameter itself is a fixed
>>> length char[16] which isn't null terminated when the label itself is 16
>>> chars long?
>>
>> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
>
> Yeah, sorry, I was on vacation for 3.5 weeks starting just before
> Memorial day, and it took me a while to get caught up. Unfortunately,
> I missed the bug in the strncpy extirpation patch, and it was't
> something that our regression tests caught. (Sometimes, the
> old/deprecated ways are just more reliable; all of ext4's strncpy()
> calls were working and had been correct for decades. :-P )
>
> Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be
> making its way to -stable.
Adding Greg and the stable list to the list of recipients: given that we
already have two reports about trouble due to this[1] he might want to
fast-track the fix (be27cd64461c45 ("ext4: use memtostr_pad() for
s_volume_name")) to 6.10.y, as it's not queued yet -- at least afaics
from looking at
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/
Ciao, Thorsten
[1] https://bugzilla.kernel.org/show_bug.cgi?id=219072 and
https://bugzilla.kernel.org/show_bug.cgi?id=219078
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Linux 6.10 regression resulting in a crash when using an ext4 filesystem
2024-07-23 10:04 ` Thorsten Leemhuis
@ 2024-07-23 11:14 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2024-07-23 11:14 UTC (permalink / raw)
To: Thorsten Leemhuis
Cc: stable@vger.kernel.org, Darrick J. Wong, Artem S. Tashkinov,
Linux Kernel Mailing List, linux-ext4, xcreativ, madeisbaer,
justinstitt, keescook, linux-hardening, Theodore Ts'o,
Kees Cook, Linux kernel regressions list
On Tue, Jul 23, 2024 at 12:04:41PM +0200, Thorsten Leemhuis wrote:
> On 23.07.24 06:11, Theodore Ts'o wrote:
> > On Mon, Jul 22, 2024 at 12:06:59AM -0700, Kees Cook wrote:
> >>> Is strscpy_pad appropriate if the @src parameter itself is a fixed
> >>> length char[16] which isn't null terminated when the label itself is 16
> >>> chars long?
> >>
> >> Nope; it needed memtostr_pad(). I sent the fix back at the end of May, but it only just recently landed:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=be27cd64461c45a6088a91a04eba5cd44e1767ef
> >
> > Yeah, sorry, I was on vacation for 3.5 weeks starting just before
> > Memorial day, and it took me a while to get caught up. Unfortunately,
> > I missed the bug in the strncpy extirpation patch, and it was't
> > something that our regression tests caught. (Sometimes, the
> > old/deprecated ways are just more reliable; all of ext4's strncpy()
> > calls were working and had been correct for decades. :-P )
> >
> > Anyway, Kees's bugfix is in Linus's tree, and it should be shortly be
> > making its way to -stable.
>
> Adding Greg and the stable list to the list of recipients: given that we
> already have two reports about trouble due to this[1] he might want to
> fast-track the fix (be27cd64461c45 ("ext4: use memtostr_pad() for
> s_volume_name")) to 6.10.y, as it's not queued yet -- at least afaics
> from looking at
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/
Now queued up. And as it was not explicitly marked for stable
inclusion, thank you for asking for it to be added.
I'll go push out a 6.10.1-rc1 in a short bit with this important fix.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-07-23 11:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-21 21:10 Linux 6.10 regression resulting in a crash when using an ext4 filesystem Artem S. Tashkinov
2024-07-22 4:19 ` Darrick J. Wong
2024-07-22 7:06 ` Kees Cook
2024-07-23 4:11 ` Theodore Ts'o
2024-07-23 10:04 ` Thorsten Leemhuis
2024-07-23 11:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).