From: Greg KH <gregkh@linuxfoundation.org>
To: Ajay Kaher <ajay.kaher@broadcom.com>
Cc: stable@vger.kernel.org, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
alexey.makhalov@broadcom.com, vasavi.sirnapalli@broadcom.com,
florian.fainelli@broadcom.com,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v5.10] ext4: fix error code saved on super block during file system abort
Date: Tue, 23 Jul 2024 15:35:29 +0200 [thread overview]
Message-ID: <2024072323-cone-mustard-94b0@gregkh> (raw)
In-Reply-To: <1721717240-8786-1-git-send-email-ajay.kaher@broadcom.com>
On Tue, Jul 23, 2024 at 12:17:19PM +0530, Ajay Kaher wrote:
> From: Gabriel Krisman Bertazi <krisman@collabora.com>
>
> [ Upstream commit 124e7c61deb27d758df5ec0521c36cf08d417f7a ]
>
> ext4_abort will eventually call ext4_errno_to_code, which translates the
> errno to an EXT4_ERR specific error. This means that ext4_abort expects
> an errno. By using EXT4_ERR_ here, it gets misinterpreted (as an errno),
> and ends up saving EXT4_ERR_EBUSY on the superblock during an abort,
> which makes no sense.
>
> ESHUTDOWN will get properly translated to EXT4_ERR_SHUTDOWN, so use that
> instead.
>
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
> Link: https://lore.kernel.org/r/20211026173302.84000-1-krisman@collabora.com
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Ajay Kaher <ajay.kaher@broadcom.com>
> ---
Both now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-07-23 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 6:47 [PATCH v5.10] ext4: fix error code saved on super block during file system abort Ajay Kaher
2024-07-23 6:47 ` [PATCH v5.10.y] ext4: Send notifications on error Ajay Kaher
2024-07-23 13:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024072323-cone-mustard-94b0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=ajay.kaher@broadcom.com \
--cc=alexey.makhalov@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=vasavi.sirnapalli@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox