public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: "Luis Henriques (SUSE)" <luis.henriques@linux.dev>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger@dilger.ca>,
	Jan Kara <jack@suse.cz>,
	Harshad Shirwadkar <harshadshirwadkar@gmail.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Subject: [PATCH v2 0/4] ext4: fix incorrect tid assumptions
Date: Wed, 24 Jul 2024 17:11:14 +0100	[thread overview]
Message-ID: <20240724161119.13448-1-luis.henriques@linux.dev> (raw)

Hi

As discussed here [1], there are a few places in ext4 and jbd2 code where it
is assumed that a tid of '0' is not valid.  Which isn't true.

This small patchset tries to fix (hopefully!) all these places.  Jan Kara
had already identified the functions that needed to be fixed.  I believe
that the only other issue is the handling of sbi->s_fc_ineligible_tid.

Each patch in this series fixes a single function; the last one also fixes
the sbi->s_fc_ineligible_tid handling.

Changes since v1:
- [PATCH 1/4] set 'has_transaction' variable on each loop iteration
- [PATCH 3/4] dropped local variable 'is_last'; renamed 'is_first' to
  'first_set' (including corresponding semantic adjustment)
- [PATCH 4/4] removed extra braces in statement

[1] https://lore.kernel.org/all/20240716095201.o7kkrhfdy2bps3rw@quack3/

*** BLURB HERE ***

Luis Henriques (SUSE) (4):
  ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit()
  ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space()
  ext4: fix incorrect tid assumption in
    jbd2_journal_shrink_checkpoint_list()
  ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible()

 fs/ext4/fast_commit.c | 15 +++++++++++----
 fs/ext4/inode.c       | 11 +++++++----
 fs/jbd2/checkpoint.c  | 14 ++++++++++----
 3 files changed, 28 insertions(+), 12 deletions(-)


             reply	other threads:[~2024-07-24 16:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 16:11 Luis Henriques (SUSE) [this message]
2024-07-24 16:11 ` [PATCH v2 1/4] ext4: fix incorrect tid assumption in ext4_wait_for_tail_page_commit() Luis Henriques (SUSE)
2024-07-24 16:30   ` Jan Kara
2024-07-24 16:11 ` [PATCH v2 2/4] ext4: fix incorrect tid assumption in __jbd2_log_wait_for_space() Luis Henriques (SUSE)
2024-07-24 16:11 ` [PATCH v2 3/4] ext4: fix incorrect tid assumption in jbd2_journal_shrink_checkpoint_list() Luis Henriques (SUSE)
2024-07-24 16:31   ` Jan Kara
2024-07-24 16:11 ` [PATCH v2 4/4] ext4: fix incorrect tid assumption in ext4_fc_mark_ineligible() Luis Henriques (SUSE)
2024-08-27 12:47 ` [PATCH v2 0/4] ext4: fix incorrect tid assumptions Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724161119.13448-1-luis.henriques@linux.dev \
    --to=luis.henriques@linux.dev \
    --cc=adilger@dilger.ca \
    --cc=harshadshirwadkar@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox