From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Ted Tso <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: don't set SB_RDONLY after filesystem errors
Date: Tue, 6 Aug 2024 12:50:03 +0200 [thread overview]
Message-ID: <20240806-passt-weitgehend-6f1a0e7f3dbb@brauner> (raw)
In-Reply-To: <20240805201241.27286-1-jack@suse.cz>
On Mon, Aug 05, 2024 at 10:12:41PM GMT, Jan Kara wrote:
> When the filesystem is mounted with errors=remount-ro, we were setting
> SB_RDONLY flag to stop all filesystem modifications. We knew this misses
> proper locking (sb->s_umount) and does not go through proper filesystem
> remount procedure but it has been the way this worked since early ext2
> days and it was good enough for catastrophic situation damage
> mitigation. Recently, syzbot has found a way (see link) to trigger
> warnings in filesystem freezing because the code got confused by
> SB_RDONLY changing under its hands. Since these days we set
> EXT4_FLAGS_SHUTDOWN on the superblock which is enough to stop all
> filesystem modifications, modifying SB_RDONLY shouldn't be needed. So
> stop doing that.
>
> Link: https://lore.kernel.org/all/000000000000b90a8e061e21d12f@google.com
> Reported-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
Thank you!
Reviewed-by: Christian Brauner <brauner@kernel.org>
next prev parent reply other threads:[~2024-08-06 10:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 20:12 [PATCH] ext4: don't set SB_RDONLY after filesystem errors Jan Kara
2024-08-06 10:50 ` Christian Brauner [this message]
2024-08-08 16:16 ` Jan Kara
2024-08-27 12:47 ` Theodore Ts'o
2024-09-30 10:15 ` Jan Stancek
2024-09-30 11:34 ` Jan Kara
2024-10-04 12:32 ` [LTP] " Amir Goldstein
2024-10-04 12:50 ` Jan Stancek
2024-10-04 13:28 ` Amir Goldstein
2024-10-04 14:31 ` Jan Kara
2024-10-04 19:33 ` Gabriel Krisman Bertazi
2024-10-06 3:38 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806-passt-weitgehend-6f1a0e7f3dbb@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).