public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Zhihao Cheng <chengzhihao@huaweicloud.com>
Cc: Christian Brauner <brauner@kernel.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-mtd@lists.infradead.org,
	chengzhihao1@huawei.com, yi.zhang@huawei.com,
	wangzhaolong1@huawei.com, yangerkun@huawei.com,
	mjguzik@gmail.com, viro@zeniv.linux.org.uk, error27@gmail.com,
	tahsin@google.com, rydercoding@hotmail.com, jack@suse.cz,
	hch@infradead.org, andreas.dilger@intel.com, tytso@mit.edu,
	richard@nod.at
Subject: Re: [PATCH v2] vfs: Don't evict inode under the inode lru traversing context
Date: Fri,  9 Aug 2024 17:15:36 +0200	[thread overview]
Message-ID: <20240809-neuanfang-recyceln-b3d99596e98f@brauner> (raw)
In-Reply-To: <20240809031628.1069873-1-chengzhihao@huaweicloud.com>

On Fri, 09 Aug 2024 11:16:28 +0800, Zhihao Cheng wrote:
> The inode reclaiming process(See function prune_icache_sb) collects all
> reclaimable inodes and mark them with I_FREEING flag at first, at that
> time, other processes will be stuck if they try getting these inodes
> (See function find_inode_fast), then the reclaiming process destroy the
> inodes by function dispose_list(). Some filesystems(eg. ext4 with
> ea_inode feature, ubifs with xattr) may do inode lookup in the inode
> evicting callback function, if the inode lookup is operated under the
> inode lru traversing context, deadlock problems may happen.
> 
> [...]

I've replaced the BUG_ON() with WARN_ON().

---

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] vfs: Don't evict inode under the inode lru traversing context
      https://git.kernel.org/vfs/vfs/c/24b0ba4e047d

      reply	other threads:[~2024-08-09 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  3:16 [PATCH v2] vfs: Don't evict inode under the inode lru traversing context Zhihao Cheng
2024-08-09 15:15 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240809-neuanfang-recyceln-b3d99596e98f@brauner \
    --to=brauner@kernel.org \
    --cc=andreas.dilger@intel.com \
    --cc=chengzhihao1@huawei.com \
    --cc=chengzhihao@huaweicloud.com \
    --cc=error27@gmail.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mjguzik@gmail.com \
    --cc=richard@nod.at \
    --cc=rydercoding@hotmail.com \
    --cc=tahsin@google.com \
    --cc=tytso@mit.edu \
    --cc=viro@zeniv.linux.org.uk \
    --cc=wangzhaolong1@huawei.com \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox