Re: [PATCH 6/6] xfs: refactor xfs_file_fallocate

Christoph Hellwig
2024-08-28T04:07:03Z

On Tue, Aug 27, 2024 at 09:07:03AM -0700, Darrick J. Wong wrote:
> On Tue, Aug 27, 2024 at 08:50:50AM +0200, Christoph Hellwig wrote:
> > Refactor xfs_file_fallocate into separate helpers for each mode,
> > two factors for i_size handling and a single switch statement over the
> > supported modes.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Much less complicated now! :)

A little more LOC, though. But I think that's worth the tradeoff.