Re: [PATCH 1/3] ext4: persist the new uptodate buffers in ext4_journalled_zero_new_buffers

[Jan Kara <jack@suse.cz>]

On Thu 29-08-24 16:54:05, zhangshida wrote:
> From: Shida Zhang <zhangshida@kylinos.cn>
> 
> For new uptodate buffers we also need to call write_end_fn() to persist the
> uptodate content, similarly as folio_zero_new_buffers() does it.
> 
> Suggested-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 941c1c0d5c6e..a0a55cb8db53 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -1389,9 +1389,9 @@ static void ext4_journalled_zero_new_buffers(handle_t *handle,
>  					size = min(to, block_end) - start;
>  
>  					folio_zero_range(folio, start, size);
> -					write_end_fn(handle, inode, bh);
>  				}
>  				clear_buffer_new(bh);
> +				write_end_fn(handle, inode, bh);
>  			}
>  		}
>  		block_start = block_end;
> -- 
> 2.33.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR